-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme/Tukan - color redesign #2249
Theme/Tukan - color redesign #2249
Conversation
Theme/Tukan - color redesign
|
@AdSchellevis @fichtner What is your opinion on my current interim solution to cross out deactivated rules?. There was a request about it see my screenshot above (firewall) and the forum for the request >> (https://forum.opnsense.org/index.php?topic=21634.15). best regards rené |
select-drop down color change
padding-right: 15px; to padding-right: 5px;
pagination >> color fix
.panel-report-tools:hover >> color fix
caret.png >> from white to black
.fw_block >> red color little change
.page-content-main >> padding form 9 to 6px
select:focus, textarea:focus, input >> color fix
.active-menu-title, .active-menu a >> color change
.btn-default:active >> color fix
.h1 px from 26 to 24
…wn-toggle >> color more dark .btn-default:active, .btn-default.active, .open > .btn-default.dropdown-toggle >> color more dark
.modal-body .table-hover > tbody > tr:hover >> color orange
select, textarea, input >> border color more dark
badge >> change color to orange
background-color: #738087; color: #FFF;
.show >> change color to green
.tokenize - color changes
font-weight h2c>> 100
font-weight:100 for h1,h2....
progress-bar change color and border
progress-bar center text
.table > tfoot > tr >> change border color
#reports-tab border-bottom
|
@fichtner I'm a little disappointed that you haven't merged the two theme updates for the next version. |
|
I am neither a robot nor at work this month :P |
|
Like all other projects and businesses in the world we do have to divide our time. Please do not underestimate the effort it takes to engineer a project like ours on a daily basis. Sometimes you just have to wait for your turn, complaining that you're not on top of the priority list this time won't do much good other than annoy people. |
|
@AdSchellevis I can confirm 100%. and with things like functional upgrades, this is 100% comprehensible. but when it comes to template updates, I miss the traceability of all the appreciation for the work you are doing. |
|
more than screenshots, which already show that it fits and I can't invest my time for the community and your project either. |
|
The way I see it complaining wastes time but waiting doesn't. I don't really see the point in the drama here. |
|
just wanted to stimulate improvement in workflow and prioritization. all good. nice day |
|
You should review your process for "stimulation" as it causes more issues than it solves currently. I guess the disappointment goes both ways. |
|
if you have more time i would like to discuss this topic, because i can't understand where the problem lies with a templete. but if i understand it, i'm 100% ready to change the way I work. I think you should always address topics, because that's the only way to improve things. |
|
It's a theme and you are constantly pushing changes to it which is perfectly fine but either you need to ask for merge explicitly when you have a state that is ready to merge or work on it further.... this PR is already at +4,024 −8,053 lines changed so it's really not reviewed in 30 seconds... For themes in general one update per release is all we can do best case so it's really not appropriate to be pushy beyond that. |
|
This IS your current release history. I really don't see your point of your work not being picked up. |
|
I have now understood that. in the future i will finish a template completely before i upload it. But this way of working came about because I never know when the next release will come and unfortunately I also notice again and again that classes are arbitrarily created in css, which sometimes you only come across by chance. if every programmer were to access the standard opnsense classes before defining his own again, i wouldn't have to do theme updates as often. but unfortunately it doesn't matter to anyone. so i have to invest the time and pay for it again. Nobody asks me how much time I have to spend on it. |
|
Please don't unload. It's pointless. You know how to create tickets early and often to solve these issues. The question still is: is this PR ready to merge or not? Which other PR do you want merged? |
|
if you use pfsense or other comparable solutions, then the same css classes are always used. at opnsense this is now an unreasonable expectation. i will follow your instructions in the future. |
|
Stop lying to yourself, every project has these issues and you know it :D |
|
so why should i lie to myself? that's a fact. the opnsense css code is pure chaos. no matter ... in the future I'll do it as requested. |
|
You know all this time I spend replying is lost elsewhere, first and foremost tending to contributor PRs? |
|
|
Thank you for your understanding. |
|
👍 me and everyone else know what a great job you do. and everyone in the community knows that you have incredible know-how that I and many others would like to have. I mean that seriously. |
|
PR READY |
|
Merged, thanks |
|
|
sorry....something did go wrong with the merging |
|
@fichtner do you need the branch again to get rid of the merging problem? Do i need to upload the code again? See the errors above. regards rené |
|
@opnsenseuser best make sure the master branch is in the state you would like to see it in before the next release slot. you can always build a theme package manually on your end. A proper use of opnsense-patch comes with strict management from the contributors end. |
|
@AdSchellevis should i upload both themes again on github? |
|
whatever went wrong here. I can not understand. I also noticed the white space and never got an error message. and always uploaded to the right branch. in between always synced with the "master". Whatever the problem, I can re-upload both themes. should I do that? |





Theme/Tukan - redesign
as requested - cross-out/strikeout text in the row for disabled rules/nat (see screenshot)
https://forum.opnsense.org/index.php?topic=21634.15