Re-order function parameters due to PHP8 deprecation notice #3043
Conversation
This changes the parameters for four functions in HAProxy.php. The ACME Client appears to call these functions with positional rather than named params so also switch the order of the parameters in these function calls in
|
This seems to be a very straightforward fix, and it fixes the RC for me. Without it, the ACME client is crashing. What is stopping it from getting merged? |
|
@jvthert Time constraints and other priorities. :) So you've tested this on an actual OPNsense installation and you can confirm that it's fully functional, right? |
|
As far as I can see this is cosmetic and deprecation notes shouldn't even be issued on production setting, but I could be wrong... |
|
So despite excluding E_DEPRECATED it seems to emit those for "reasons". FWIW, 22.7 is already built and in image testing phase so this will likely be included in 22.7.1. |
|
Ok, for one caused by migration script, but also indicating it's benign https://github.com/opnsense/core/blob/1fa0cb3e2d18fd68cfeead29a72f033436d284ec/src/opnsense/mvc/script/run_migrations.php#L31 |
|
Merged, thanks! |
This changes the parameters for four functions in HAProxy.php.
The ACME Client appears to call these functions with positional rather than named params so also switch the order of the parameters in these function calls
Fixes: #3042