dns/ddclient - add "get" protocol in custom service type

[DaCookie4u]

I am loving this new "custom POST" option, but my provider unfortunately only supports GET-requests. POST-requests fail with a CSRF validation.

Since I am unable to change the code on my providers side I decided to implemented a "custom GET" option. This does the same work only with a GET-request instead of POST.

I tried to keep the changes as small as possible. Not sure if that is wanted, but this way 99% of the current code is used and only the request-type changes.

[fichtner]

@DaCookie4u thanks, at first glance this looks good. @AdSchellevis will let you know about cleanups in a bit. He also mentioned we could add PUT as well while at it.

Cheers,
Franco

[fichtner]

thanks, LGTM

[DaCookie4u]

I liked the PUT idea, so I put it in. Hope that was OK.

I also switched the getattr() method to the general request method. I have the feeling that is cleaner and somehow safer.

[DaCookie4u]

BTW, how long does it for plugins to be packaged to the main repository after being committed to master? I couldn't find any info on the exact process that leads from master to package.

[fichtner]

master branch merges land in the next development version of the upcoming release. If we can wrap up tomorrow that would be 23.7.2 for early next week.

But I think these changes are simple enough to be pushed to stable as well so they will be released directly in 23.7.2.

[AdSchellevis]

@DaCookie4u looks good, thanks!