-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme-Cicada #592
Closed
Closed
Theme-Cicada #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 23260aa)
Error: Attribute "type" not allowed on element <i> at this point. (cherry picked from commit 9960e5a)
Error: Attribute "for" not allowed on element "div" at this point. Attributes for element "div": http://www.w3.org/html/wg/drafts/html/master/single-page.html#the-div-element HTML attribute reference: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes The "Output" element: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/output Attributes for element "output": http://www.w3.org/html/wg/drafts/html/master/single-page.html#the-output-element (cherry picked from commit 7898450)
(cherry picked from commit 058b9c8)
(cherry picked from commit 7136473)
(cherry picked from commit 4cabed4)
(cherry picked from commit 0dfdb00)
(cherry picked from commit 75e20ae)
(cherry picked from commit 605fd5e)
(cherry picked from commit 4304f2d)
(cherry picked from commit 9d7a5ff)
(cherry picked from commit a091aec)
This is recommended as Chrome gave us CRSF issues with this "feature" for no apparent reason. We don't have minified stylesheets...
Warning: The type attribute is unnecessary for JavaScript resources. HTML5: Edition for Web Authors http://www.w3.org/TR/2014/REC-html5-20141028/scripting-1.html The default, which is used if the attribute is absent, is "text/javascript". The Script element https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script HTML5 specification urges authors to omit the attribute rather than provide a redundant MIME type. (cherry picked from commit 5533702)
PR: opnsense/core#1835 (cherry picked from commit 8ebb3bd)
(cherry picked from commit bf3cbb8)
(cherry picked from commit 047b0c1)
PR: https://forum.opnsense.org/index.php?topic=7210.0 (cherry picked from commit 8d6debc)
(cherry picked from commit 9f36d9d)
|
@opnsenseuser12123 something went wrong when you created your branch - which makes this branch not really mergeable. You should fork a feature branch from the |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first time a make a pull request.
This is the newest template (Cicada) i made.
I hope its the right way for uploading the template to the main repo?
Forum Link to the Cicada Template:
https://forum.opnsense.org/index.php?topic=7524.0
theme-cicada.zip