Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme-Cicada #592

Closed
wants to merge 62 commits into from
Closed

Theme-Cicada #592

wants to merge 62 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 10, 2018

This is my first time a make a pull request.
This is the newest template (Cicada) i made.

I hope its the right way for uploading the template to the main repo?

Forum Link to the Cicada Template:
https://forum.opnsense.org/index.php?topic=7524.0

theme-cicada.zip

fichtner and others added 30 commits January 4, 2018 17:02
Error: Attribute "type" not allowed on element <i> at this point.
(cherry picked from commit 9960e5a)
(cherry picked from commit db06a4d)
(cherry picked from commit a2091db)
(cherry picked from commit 76a866f)
(cherry picked from commit 0dfdb00)
(cherry picked from commit 129acfd)
(cherry picked from commit 23035f1)
(cherry picked from commit 7bc1c20)
(cherry picked from commit 24caebf)
(cherry picked from commit 9d7a5ff)
(cherry picked from commit a091aec)
This is recommended as Chrome gave us CRSF issues with this "feature"
for no apparent reason.  We don't have minified stylesheets...
fichtner and others added 28 commits February 1, 2018 09:44
Warning: The type attribute is unnecessary for JavaScript resources.

HTML5: Edition for Web Authors
http://www.w3.org/TR/2014/REC-html5-20141028/scripting-1.html
The default, which is used if the attribute is absent, is "text/javascript".

The Script element
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script
HTML5 specification urges authors to omit the attribute rather than provide a redundant MIME type.

(cherry picked from commit 5533702)
(cherry picked from commit bf3cbb8)
(cherry picked from commit 047b0c1)
@fabianfrz
Copy link
Member

@opnsenseuser12123 something went wrong when you created your branch - which makes this branch not really mergeable. You should fork a feature branch from the master branch and add your commits. You should not work with the stable branches.

@ghost ghost closed this Mar 10, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants