add All-Inkl.com to DynDns services #692
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All-Inkl is one of the biggest european providers and offers a DynDns service. The code was tested extensively and checks the result for its correctness. The code is a fork from pfsense/pfsense#3223
fichtner
reviewed
May 28, 2018
| @@ -132,6 +132,7 @@ function dyndns_list() | |||
| 'selfhost' => 'SelfHost', | |||
| 'strato' => 'STRATO', | |||
| 'zoneedit' => 'ZoneEdit', | |||
| 'all-inkl' => 'All-Inkl.com', | |||
There was a problem hiding this comment.
Can you merge this into #693 for a clean PR?
Also, the list is sorted alphabetically so it should be entry number 2. :)
|
I created a pull request in your repository to merge your two branches together. When you click the merge button, this commit will be in the other pull request. Please also add the change @fichtner requested to your patch-2 branch. @tamara2k Please click the merge button here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All-Inkl is one of the biggest european providers and offers a DynDns service. The code was tested extensively and checks the result for its correctness. The code is a fork from pfsense/pfsense#3223