security/openconnect: add field to add certificate hash #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fichtner
reviewed
Jul 8, 2018
| <id>general.servercert</id> | ||
| <label>Certificate Hash</label> | ||
| <type>text</type> | ||
| <help>If you have a wildcard certificate or the CA is untrusted, you have to enter the SHA hash of the certificate to force a connect.</help> |
There was a problem hiding this comment.
I can add a dropdown to choose for both
There was a problem hiding this comment.
only sha256 is ok, but it should say so in the label and help text
fichtner
reviewed
Jul 8, 2018
| @@ -23,5 +23,9 @@ | |||
| <default>password</default> | |||
| <Required>Y</Required> | |||
| </password> | |||
| <servercert type="TextField"> | |||
| <Required>N</Required> | |||
| <ValidationMessage>Please provide a valid hash.</ValidationMessage> | |||
There was a problem hiding this comment.
No validation logic no validation error?
There was a problem hiding this comment.
Can you have a look in one of the last commits in PR? I had a validator nur it wasn't accepted.
There was a problem hiding this comment.
which format does it accept? XXXXXX.. or XX:XX:XX..?
|
Now it's correct ... |
fichtner
reviewed
Jul 8, 2018
| <multiple>N</multiple> | ||
| <Required>Y</Required> | ||
| <OptionValues> | ||
| <sha256>sha256</sha256> |
fichtner
reviewed
Jul 8, 2018
| <Required>Y</Required> | ||
| <OptionValues> | ||
| <sha256>sha256</sha256> | ||
| <sha1>sha1</sha1> |
|
fixed .. |
|
Merged, thanks! |
fichtner
pushed a commit
that referenced
this pull request
Jul 10, 2018
(cherry picked from commit 7d40d1a)
fichtner
pushed a commit
that referenced
this pull request
Jul 10, 2018
(cherry picked from commit 7d40d1a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If using wildcard cert or CA is untrusted you have to add the certificate hash manually.
https://forum.opnsense.org/index.php?topic=9090.0