net/haproxy: release 2.8

[fraenki]

New features

• support truly seamless reloads (net/haproxy: seamless reloads with HAProxy 1.8 #224)
• add support for the "map" feature (net/haproxy: add "map" support to haproxy #180)

Bugfixes

• fix reload of service template in "reconfigure" action (HAProxy remote stats settings won't get applied #690; introduced in 7381101)
• enabling "hard stop" mode resulted in an invalid "hardrestart" RC command

Enhancements

• use "reload" instead of "restart" RC action
• if "reload" fails, also issue a "restart" command (required when enabling seamless reloads)
• start progress animation (spinner) earlier when applying settings

[fraenki]

With seamless reloads enabled

$ ab -r -c 10 -n100000 http://opnsense-haproxy-test/
Concurrency Level: 10
Time taken for tests: 25.575 seconds
Complete requests: 100000
Failed requests: 0

Without seamless reloads

$ ab -r -c 10 -n100000 http://opnsense-haproxy-test/
Concurrency Level: 10
Time taken for tests: 25.719 seconds
Complete requests: 100000
Failed requests: 20

[fraenki]

I've submitted a patch for the FreeBSD port, because the seamless reload feature requires a small modification to the RC script:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230305

[fichtner]

This requires HAProxy 1.8.13? Is the FreeBSD modification already included or do we need to pull this into our tree as well?

[fraenki]

@fichtner, HAProxy 1.8.13 is recommended because it fixes a related bug. The FreeBSD modifications are not yet included, we need to pull this into our tree or wait until it gets committed upstream.

[fichtner]

Let‘s wait for FreeBSD to not risk changing it twice here erst case. Do you have the PR link over at FreeBSD?

…

On 3. Aug 2018, at 23:17, Frank Wall ***@***.***> wrote: @fichtner, HAProxy 1.8.13 is recommended because it fixes a related bug. The FreeBSD modifications are not yet included, we need to pull this into our tree or wait until it gets committed upstream. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[fraenki]

@fichtner The upstream patch was commited in the FreeBSD ports tree. I'll merge this now, please pull in the required pieces in the ports repo too. :)

[fichtner]

Ack. Will do when I’m back in September. Thanks for the FreeBSD submission 😊

[fichtner]

FYI 697c98b8 -- we're all good so 2.8 will be in 18.7.2. Thanks!

[ma-karai]

are there plans to import existing haproxy configs?

[fraenki]

@bott0r Please open a new issue for unrelated requests.