Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns/dnscrypt-proxy: new plugin #965

Merged
merged 49 commits into from
Nov 19, 2018
Merged

dns/dnscrypt-proxy: new plugin #965

merged 49 commits into from
Nov 19, 2018

Conversation

mimugmail
Copy link
Member

As the name says ... :)

Copy link
Member

@fabianfrz fabianfrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some quick findings

the required thing is at multiple places

@fichtner
Copy link
Member

fichtner commented Nov 11, 2018

first things first, name should be "dnscrypt-proxy" (directory) ;)

@fichtner fichtner self-assigned this Nov 11, 2018
@fichtner fichtner changed the title dns/dnscrypt-proxy2: new plugin dns/dnscrypt-proxy: new plugin Nov 11, 2018
@mimugmail
Copy link
Member Author

whoopsie ...

Copy link
Member

@fichtner fichtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small suggestions, otherwise looking shiny 👍

fichtner and others added 3 commits November 16, 2018 15:51
…_dnscryptproxy.conf

Co-Authored-By: mimugmail <m.muenz@gmail.com>
…_dnscryptproxy.conf

Co-Authored-By: mimugmail <m.muenz@gmail.com>
…nscryptproxy/forms/dialogEditDnscryptproxyCloak.xml

Co-Authored-By: mimugmail <m.muenz@gmail.com>
@mimugmail
Copy link
Member Author

Thanks for your time @fabianfrz and @fichtner ❤️

@mimugmail
Copy link
Member Author

@fichtner any concerns merging this to have devel pkg with next release? :)

@fichtner
Copy link
Member

There were 3 pending discussions, but it seems they were addressed. I'm merging this now. Thanks!

@fichtner fichtner merged commit bface5b into opnsense:master Nov 19, 2018
fichtner pushed a commit that referenced this pull request Nov 19, 2018
(cherry picked from commit bface5b)
(cherry picked from commit 9499a73)
@mimugmail mimugmail deleted the dns2 branch December 4, 2018 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants