-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dns/dnscrypt-proxy: new plugin #965
Conversation
dns/dnscrypt-proxy2/src/opnsense/mvc/app/models/OPNsense/Dnscryptproxy/Cloak.xml
Outdated
Show resolved
Hide resolved
dns/dnscrypt-proxy2/src/opnsense/mvc/app/models/OPNsense/Dnscryptproxy/General.xml
Outdated
Show resolved
Hide resolved
dns/dnscrypt-proxy2/src/opnsense/mvc/app/models/OPNsense/Dnscryptproxy/General.xml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some quick findings
the required thing is at multiple places
dns/dnscrypt-proxy2/src/opnsense/mvc/app/models/OPNsense/Dnscryptproxy/Menu/Menu.xml
Outdated
Show resolved
Hide resolved
dns/dnscrypt-proxy2/src/opnsense/mvc/app/models/OPNsense/Dnscryptproxy/Whitelist.xml
Outdated
Show resolved
Hide resolved
…yptproxy/Menu/Menu.xml Co-Authored-By: mimugmail <m.muenz@gmail.com>
|
first things first, name should be "dnscrypt-proxy" (directory) ;) |
|
whoopsie ... |
...c/opnsense/mvc/app/controllers/OPNsense/Dnscryptproxy/forms/dialogEditDnscryptproxyCloak.xml
Outdated
Show resolved
Hide resolved
dns/dnscrypt-proxy/src/opnsense/service/conf/actions.d/actions_dnscryptproxy.conf
Outdated
Show resolved
Hide resolved
dns/dnscrypt-proxy/src/opnsense/service/conf/actions.d/actions_dnscryptproxy.conf
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small suggestions, otherwise looking shiny 👍
…_dnscryptproxy.conf Co-Authored-By: mimugmail <m.muenz@gmail.com>
…_dnscryptproxy.conf Co-Authored-By: mimugmail <m.muenz@gmail.com>
…nscryptproxy/forms/dialogEditDnscryptproxyCloak.xml Co-Authored-By: mimugmail <m.muenz@gmail.com>
|
Thanks for your time @fabianfrz and @fichtner ❤️ |
|
@fichtner any concerns merging this to have devel pkg with next release? :) |
|
There were 3 pending discussions, but it seems they were addressed. I'm merging this now. Thanks! |
As the name says ... :)