Skip to content

Commit

Permalink
rtsold: auto-probe point to point interfaces
Browse files Browse the repository at this point in the history
  • Loading branch information
@fichtner
fichtner committed Feb 21, 2021
1 parent 3333a87 commit 2485dc0
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion usr.sbin/rtsold/rtsold.8
View file
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ The options are as follows:
.It Fl a
Autoprobe outgoing interfaces.
.Nm
will try to find any non-loopback, non-point-to-point, IPv6-capable interfaces
will try to find any non-loopback, IPv6-capable interfaces
and send router solicitation messages on all of them.
.It Fl d
Enable debugging.
Expand Down
2 changes: 0 additions & 2 deletions usr.sbin/rtsold/rtsold.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -787,8 +787,6 @@ autoifprobe(void)
for (ifa = ifap; ifa; ifa = ifa->ifa_next) {
if ((ifa->ifa_flags & IFF_UP) == 0)
continue;
if ((ifa->ifa_flags & IFF_POINTOPOINT) != 0)
continue;
if ((ifa->ifa_flags & IFF_LOOPBACK) != 0)
continue;
if ((ifa->ifa_flags & IFF_MULTICAST) == 0)
Expand Down

5 comments on commit 2485dc0

@marjohn56
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK,.

@fichtner
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. What is a bit disappointing is that looking at the code radvd is emulating stuffing interfaces in the command line so that makes their historical -a restriction even more weird and doesn’t help us a lot in dynamic situations or when wanting to use SIGHUP. Luckily rtsold is not that high profile that it matters.

@fichtner
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS: And, yes, rtsold is one of the few things that is still patched vs. FreeBSD where we want the router address from the script...

@marjohn56
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did radvd come into this? You mean rtsold I assume?
OK... so it's VERY old patch, understood. We don't sighup rtsold, we always kill it.

/* always kill rtsold in case of reconfigure */
killbypid('/var/run/rtsold.pid', 'TERM', true);

@fichtner
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, typo in first comment, yes.

Please sign in to comment.