Skip to content

Commit

Permalink
vlan: do not protect PCP write with the sysctl
Browse files Browse the repository at this point in the history
pf will unconditionally "set prio", so this will fail if the
sysctl is off.  The sysctl, however, introduces a side-effect
so we would rather keep the default behaviour.  The allocation
slowdown is already taking place, so this in the worst case
only adds a list traversal / lookup.

PR: https://forum.opnsense.org/index.php?topic=6714.0
  • Loading branch information
fichtner committed Dec 30, 2017
1 parent 5c70e2a commit dabc3cf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sys/net/if_vlan.c
Original file line number Diff line number Diff line change
Expand Up @@ -1102,7 +1102,7 @@ vlan_transmit(struct ifnet *ifp, struct mbuf *m)
* knows how to find the VLAN tag to use, so we attach a
* packet tag that holds it.
*/
if (vlan_mtag_pcp && (mtag = m_tag_locate(m, MTAG_8021Q,
if ((mtag = m_tag_locate(m, MTAG_8021Q,
MTAG_8021Q_PCP_OUT, NULL)) != NULL)
tag = EVL_MAKETAG(ifv->ifv_vid, *(uint8_t *)(mtag + 1), 0);
else
Expand Down

0 comments on commit dabc3cf

Please sign in to comment.