From 46aa6e54c04ce03bd28bb84e7d102277da259219 Mon Sep 17 00:00:00 2001
From: Rajat Talesra <rajattalesra4914@gmail.com>
Date: Thu, 6 Aug 2020 18:26:21 +0530
Subject: [PATCH] Fix #1562: Bug fix promoted story list (#1564)

* Fixed promoted stories

* Nit revert

Co-authored-by: Rajat Talesra <talesra@google.com>
---
 .../oppia/app/home/HomeFragmentPresenter.kt    | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/app/src/main/java/org/oppia/app/home/HomeFragmentPresenter.kt b/app/src/main/java/org/oppia/app/home/HomeFragmentPresenter.kt
index 512e0fbabbd..1cc4876facf 100644
--- a/app/src/main/java/org/oppia/app/home/HomeFragmentPresenter.kt
+++ b/app/src/main/java/org/oppia/app/home/HomeFragmentPresenter.kt
@@ -180,10 +180,20 @@ class HomeFragmentPresenter @Inject constructor(
     getAssumedSuccessfulOngoingStoryList().observe(
       fragment,
       Observer<OngoingStoryList> {
-        it.recentStoryList.take(limit).forEach { promotedStory ->
-          val recentStory = PromotedStoryViewModel(activity, internalProfileId)
-          recentStory.setPromotedStory(promotedStory)
-          promotedStoryList.add(recentStory)
+        promotedStoryList.clear()
+        if (it.recentStoryCount != 0) {
+          it.recentStoryList.take(limit).forEach { promotedStory ->
+            val recentStory = PromotedStoryViewModel(activity, internalProfileId)
+            recentStory.setPromotedStory(promotedStory)
+            promotedStoryList.add(recentStory)
+          }
+        } else {
+          // TODO(#936): Optimise this as part of recommended stories.
+          it.olderStoryList.take(limit).forEach { promotedStory ->
+            val oldStory = PromotedStoryViewModel(activity, internalProfileId)
+            oldStory.setPromotedStory(promotedStory)
+            promotedStoryList.add(oldStory)
+          }
         }
         topicListAdapter.notifyItemChanged(1)
       }