New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2841: Update the documentation on oppia.github.io #34

Merged
merged 4 commits into from Mar 25, 2017

Conversation

Projects
None yet
2 participants
@terrameijar
Contributor

terrameijar commented Mar 23, 2017

Edits of the TheExplorationGallery.html page. I renamed this page to TheExplorationLibrary.html, changed all references to exploration gallery to library and rephrased some of the text.

@terrameijar terrameijar changed the title from Dev to Fix #2841: Update the documentation on oppia.github.io Mar 23, 2017

@seanlip

This is great. Thank you for the changes! I have a few comments.

app.js Outdated
@@ -33,8 +33,8 @@ oppiaGithubPages.config(['$routeProvider', function($routeProvider) {
projectTag: 'Key concepts in Oppia'
})
.when('/TheExplorationGallery', {

This comment has been minimized.

@seanlip

seanlip Mar 23, 2017

Member

Should this be changed to /TheExplorationLibrary as well?

</h2>

<p>
After signing in to Oppia, you'll end up on the Home page. Even before you
start creating your own explorations, there are a number of things you can
do. You can click on the icon at the top left corner of the page to access
the blog, join the discussion forum or access the Participation Playbook.
do. Hover the cursor over the about menu in the navigation bar at the top right of the page to access the blog, join the discussion forum or learn how to get started.

This comment has been minimized.

@seanlip

seanlip Mar 23, 2017

Member

Consider keeping lines to 80 chars or so, similar to the rest of the file -- it makes it a bit easier to read when reviewing.

Also, suggest: "about menu" --> "About menu"

@@ -36,7 +34,7 @@
the gallery shows only mathematics explorations.
</p>

<img src="static/images/galleryCategoryHighlighted.png" width="100%">
<img src="static/images/libraryCategoryHighlighted.png" width="100%">

This comment has been minimized.

@seanlip

seanlip Mar 23, 2017

Member

Shouldn't this picture show the user selecting "Mathematics" from the category dropdown, rather than their typing "Mathematics" into the search bar?

This comment has been minimized.

@terrameijar

terrameijar Mar 25, 2017

Contributor

Right, I have edited the screenshot.

@seanlip

LGTM. Thanks!

@seanlip seanlip merged commit d557440 into oppia:master Mar 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment