Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Music interaction doesn't work #10385

Closed
nishantwrp opened this issue Aug 19, 2020 · 2 comments · Fixed by #10395
Closed

Music interaction doesn't work #10385

nishantwrp opened this issue Aug 19, 2020 · 2 comments · Fixed by #10395
Assignees
@kevintab95
Projects
Learner and Creator Experience

Comments

@nishantwrp
Copy link
Contributor

nishantwrp commented Aug 19, 2020 •
edited

Try to create an exploration with Music Interaction. You'll observe that it doesn't work. And there is this console error

TypeError: Cannot read property 'add' of undefined

Screenshot_20200819_195310
@nishantwrp
Copy link
Contributor Author

/cc @oppia/lace-team

@kevintab95 kevintab95 added this to Awaiting Triage in Learner and Creator Experience via automation Aug 21, 2020
@kevintab95 kevintab95 moved this from Awaiting Triage to Editor Pages in Learner and Creator Experience Aug 21, 2020
@kevintab95 kevintab95 mentioned this issue Aug 21, 2020
Closed
4 tasks
@kevintab95 kevintab95 self-assigned this Aug 21, 2020
@kevintab95 kevintab95 linked a pull request Aug 21, 2020 that will close this issue
Fix #10385: Initialize directiveSubscriptions in music notes interaction directive #10411
Closed
4 tasks
@Showtim3 Showtim3 moved this from Editor Pages to Interaction Issues in Learner and Creator Experience Aug 23, 2020
@kevintab95 kevintab95 linked a pull request Aug 24, 2020 that will close this issue
Fix #10083: Fixes rogue events, migrates recent events and completely eradicates $broadcast/$on pairs from the codebase #10395
Merged
4 tasks
@kevintab95
Copy link
Member

This has been fixed by #10395.

Learner and Creator Experience automation moved this from Interaction Issues to Done Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevintab95 kevintab95

Labels
None yet
Projects
No open projects
Learner and Creator Experience
  
Done
Milestone
No milestone
2 participants
@kevintab95 @nishantwrp