Allow editing a suggestion which is under review

[nithusha21]

The author of the suggestion should be able to edit a suggestion after it has been submitted for review. The reviewer should also be able to edit the suggestion and then accept it. This would help out in many scenarios. For example, delaying accepting a suggestion till the author fixes a typo would slow down the lesson creation/improvement process.

This would mostly involve backend changes, and a few frontend changes. Here is roughly a list of changes that would be necessary to make this work. Each of the tasks may be completed in independent PRs or they may be grouped up and completed together.

Backend

• Add a service function that will allow modification of the suggestion in review. (relevant file: core/domain/suggestion_services.py)
• Add a controller that will handle requests to modify a suggestion in review. Appropriate permissions need to be added to restrict who can edit the suggestion. (relevant files: core/domain/acl_decorators.py, core/controllers/suggestion.py)

Frontend

• The view suggestion modal needs to be modified to also allow editing the suggestion (in the right pane).

[hemant0308]

I will working on this.!
@nithusha21
@kevinlee12

[wirelessfire]

I can work on either backend part of this, can I be assigned?

[nithusha21]

Hi @hemant0308 are you working on some part of this issue? If not, assigning @wirelessfire for the backend task. Which one of the tasks would you like to take up?

[hemant0308]

Sure.!@nithusha21
I will work on frontend part then

[wirelessfire]

I can make the function to allow for the modification of the suggestion.

[nithusha21]

Cool, assigning you for the same.

[jacobdavis11]

@hemant0308 @wirelessfire how is this going?

[hemant0308]

working on this.!
will open a PR shortly
@jacobdavis11

[wirelessfire]

Still working on it, should be done soon.

…

On Mon, Oct 29, 2018 at 5:17 PM Jacob Davis ***@***.***> wrote: @hemant0308 <https://github.com/hemant0308> @wirelessfire <https://github.com/wirelessfire> how is this going? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5726 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ApRpKKWTmh2-wvMWpYZBesBG37JBefyfks5up3BQgaJpZM4XH_58> .

[DubeySandeep]

@hemant0308 @wirelessfire , how is this going?

[nithusha21]

Hi @hemant0308, @wirelessfire any updates?

[nithusha21]

Deassigning @hemant0308 and @wirelessfire due to lack of response. Assigning @import-keshav as he is interested to work on this issue.

[jacobdavis11]

@import-keshav are you still working on this?

[import-keshav]

Hello, @jacobdavis11 I created a PR for this. And only some comments are pending to resolve. But since I am busy in my GSoC project so I leave it for now (closed the opened PR). Will come back to it and merge the PR ASAP.
thanks

[oppiabot]

Hi @oppia/core-maintainers, this issue is not assigned to any project. Can you please update the same? Thanks!

[sagangwee]

Reviewers can apply edits to suggestions before accepting them.