Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweet has wrong text #9708

Closed
nishantwrp opened this issue Jun 28, 2020 · 8 comments · Fixed by #11516
Closed

Tweet has wrong text #9708

nishantwrp opened this issue Jun 28, 2020 · 8 comments · Fixed by #11516

Comments

@nishantwrp
Copy link
Contributor

nishantwrp commented Jun 28, 2020

Describe the bug
Feature of sharing a explo on a tweet has wrong text.

To Reproduce
Steps to reproduce the behavior:

  1. Go to a exploration.
  2. Click on Info.
  3. Try to share the explo as a tweet.

Observed behavior
Check out this interactive lesson I created on Oppia - a free platform for teaching and learning! https://www.oppia.org/explore/-tMgcP1i_4au

Expected behavior
The tweet states that I created the exploration while I didn't.

@darksun27
Copy link
Contributor

darksun27 commented Jul 5, 2020

The sharing text could just say Check out this interactive lesson on Oppia. Making it universal for the creators as well as players.

@nishantwrp
Copy link
Contributor Author

nishantwrp commented Jul 5, 2020

@darksun27 Yeah, it can be done. However I would like to check it once with the @oppia/lace-team.

@kevintab95 kevintab95 added this to Awaiting Triage in Learner and Creator Experience Aug 28, 2020
@seanlip seanlip moved this from Awaiting Triage to Learner Pages (@aks681) in Learner and Creator Experience Aug 30, 2020
@atpug22
Copy link
Contributor

atpug22 commented Dec 25, 2020

@nishantwrp @aks681 Can I work on this issue?

@nishantwrp
Copy link
Contributor Author

nishantwrp commented Dec 26, 2020

Yup, you can. Assigned you.

@nishantwrp nishantwrp assigned atpug22 and unassigned aks681 Dec 26, 2020
@atpug22
Copy link
Contributor

atpug22 commented Dec 26, 2020

@nishantwrp so we have to change the text only to this text mentioned in this comment??

The sharing text could just say Check out this interactive lesson on Oppia. Making it universal for the creators as well as players.

@nishantwrp
Copy link
Contributor Author

nishantwrp commented Dec 26, 2020

Looks good to me. But would like to defer this to @kevintab95 @aks681.

@atpug22
Copy link
Contributor

atpug22 commented Dec 27, 2020

@kevintab95 @aks681 So I have to change the text only as mentioned in the comments above?

@kevintab95
Copy link
Member

kevintab95 commented Dec 27, 2020

Yep, I think that should be fine. Thanks!

Learner and Creator Experience automation moved this from Lesson-Related Learner Pages (@aks681) to Done Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

6 participants