Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscriptions sort in learners dashboard doesn't work correctly. #9797

Closed
nishantwrp opened this issue Jul 5, 2020 · 0 comments · Fixed by #9798
Closed

Subscriptions sort in learners dashboard doesn't work correctly. #9797

nishantwrp opened this issue Jul 5, 2020 · 0 comments · Fixed by #9798
Assignees

Comments

@nishantwrp
Copy link
Contributor

nishantwrp commented Jul 5, 2020

It can be seen here that the sorting is done by the following keys

public static SUBSCRIPTION_SORT_BY_KEYS_AND_I18N_IDS = {
USERNAME: {
key: 'subscriber_username',
i18nId: 'I18N_PREFERENCES_USERNAME'
},
IMPACT: {
key: 'subscriber_impact',
i18nId: 'I18N_CREATOR_IMPACT'
}
};

But the backend returns the following keys

subscription_summary = {
'creator_picture_data_url': (
creator_settings.profile_picture_data_url),
'creator_username': creator_settings.username,
'creator_impact': (
user_services.get_user_impact_score(
creators_subscribed_to[index]))
}

Note - I'll be fixing this in my next PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant