Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename all .scripts.ts files to .import.ts #10132

Merged
merged 1 commit into from Aug 3, 2020
Merged

Rename all .scripts.ts files to .import.ts #10132

merged 1 commit into from Aug 3, 2020

Conversation

nishantwrp
Copy link
Contributor

@nishantwrp nishantwrp commented Jul 31, 2020

Overview

  1. This PR fixes or fixes part of #[fill_in_number_here].
  2. This PR does the following: Rename all .scripts.ts files to .import.ts.

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

PR Pointers

  • Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays
  • Never force push. If you do, your PR will be closed.

@oppiabot
Copy link

oppiabot bot commented Jul 31, 2020

Assigning @sagangwee, @vojtechjelinek, @kevintab95, @nithusha21, @DubeySandeep, @aks681, @Showtim3, @jameesjohn for the first pass review of this PR. Thanks!

Copy link
Contributor

@Showtim3 Showtim3 left a comment

Hey @nishantwrp The changes LGTM but why are we doing this? (Sorry i lack the context)

@Showtim3 Showtim3 assigned nishantwrp and unassigned Showtim3 Jul 31, 2020
@nishantwrp
Copy link
Contributor Author

nishantwrp commented Aug 1, 2020

Hi @Showtim3, actually when I added this file (https://github.com/oppia/oppia/blob/develop/core/templates/third-party-imports/ckeditor.import.ts) @vojtechjelinek thought that .import.ts naming is better than scripts.ts naming.

@nishantwrp nishantwrp assigned Showtim3 and unassigned nishantwrp Aug 1, 2020
Copy link
Member

@kevintab95 kevintab95 left a comment

LGTM, thanks @nishantwrp!

@kevintab95 kevintab95 removed their assignment Aug 1, 2020
Copy link
Member

@vojtechjelinek vojtechjelinek left a comment

@vojtechjelinek vojtechjelinek removed their assignment Aug 1, 2020
@Showtim3 Showtim3 removed their assignment Aug 2, 2020
@nishantwrp
Copy link
Contributor Author

nishantwrp commented Aug 2, 2020

@vojtechjelinek done! Also @seanlip, can we merge this without the approval of other codeowners since this is a repititive change?

@seanlip
Copy link
Member

seanlip commented Aug 2, 2020

Yup that's fine. Just ping me once the Travis checks pass and I'll merge it!

@nishantwrp
Copy link
Contributor Author

nishantwrp commented Aug 2, 2020

@seanlip the checks have passed!

@nishantwrp nishantwrp assigned seanlip and unassigned nishantwrp Aug 2, 2020
@seanlip seanlip merged commit a3b8285 into oppia:develop Aug 3, 2020
6 checks passed
@nishantwrp nishantwrp deleted the import-script branch Aug 3, 2020
shavavo pushed a commit to shavavo/oppia that referenced this pull request Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants