Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new eslint checks #10187

Merged
merged 4 commits into from Aug 14, 2020
Merged

Introduce new eslint checks #10187

merged 4 commits into from Aug 14, 2020

Conversation

nishantwrp
Copy link
Contributor

@nishantwrp nishantwrp commented Aug 6, 2020

Overview

  1. This PR fixes or fixes part of #[fill_in_number_here].
  2. This PR does the following: Introduce new eslint checks

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

PR Pointers

  • Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays
  • Never force push. If you do, your PR will be closed.

@oppiabot
Copy link

oppiabot bot commented Aug 6, 2020

Assigning @DubeySandeep for the first-pass review of this pull request. Thanks!

Copy link
Member

@vojtechjelinek vojtechjelinek left a comment

Thank looks quite good, just one question.

@@ -238,6 +238,32 @@
"unused-imports/no-unused-imports-ts": "error",
"@typescript-eslint/no-explicit-any": ["error"],
"@typescript-eslint/semi": ["error"],
"@typescript-eslint/ban-types": [
Copy link
Member

@vojtechjelinek vojtechjelinek Aug 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@nishantwrp nishantwrp Aug 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there are two extra rules there. But I think we can work on them a little later deciding a proper convention for them.

We can mark it as a todo in the eslint sheet?

Copy link
Member

@vojtechjelinek vojtechjelinek Aug 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, not a problem, let's mark it as TODO in the sheet and do it later.

Copy link
Member

@vojtechjelinek vojtechjelinek left a comment

LGTM!

@oppiabot
Copy link

oppiabot bot commented Aug 8, 2020

Hi @nishantwrp. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

Copy link
Member

@DubeySandeep DubeySandeep left a comment

LGTM for the codeowner files.

@@ -133,7 +133,7 @@ interface MIDI {
setController: (
channelId: number, type: Object, value: Object, delay: number) => void;
setDefaultPlugin: (midi: Obejct) => void;
Copy link
Member

@DubeySandeep DubeySandeep Aug 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Object* (Not related to this PR changes!)

Copy link
Member

@DubeySandeep DubeySandeep Aug 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do something to avoid such a typo in these files? (Just wanted to know if it's possible to do something here!)

Copy link
Contributor Author

@nishantwrp nishantwrp Aug 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done! There is an issue filed for this. (#10219)

@DubeySandeep DubeySandeep removed their assignment Aug 8, 2020
Copy link
Contributor

@Showtim3 Showtim3 left a comment

Changes look great. Thanks!
One question though, Is this convention documented in the wiki(To use [], instead of Array<>)

@nishantwrp
Copy link
Contributor Author

nishantwrp commented Aug 9, 2020

@nishantwrp
Copy link
Contributor Author

nishantwrp commented Aug 9, 2020

Copy link
Member

@kevintab95 kevintab95 left a comment

LGTM for codeowner files. Thanks @nishantwrp!

@kevintab95 kevintab95 removed their assignment Aug 9, 2020
@brianrodri brianrodri removed their assignment Aug 9, 2020
Hudda
Hudda approved these changes Aug 9, 2020
@Hudda Hudda removed their assignment Aug 9, 2020
Copy link
Member

@nithusha21 nithusha21 left a comment

LGTm for codeowner files!

@nithusha21 nithusha21 removed their assignment Aug 11, 2020
@nishantwrp
Copy link
Contributor Author

nishantwrp commented Aug 11, 2020

Copy link
Member

@srijanreddy98 srijanreddy98 left a comment

LGTM for codeowner files!

@srijanreddy98 srijanreddy98 removed their assignment Aug 11, 2020
aks681
aks681 approved these changes Aug 11, 2020
Copy link
Member

@aks681 aks681 left a comment

Lgtm for codeowner files.

@aks681 aks681 removed their assignment Aug 11, 2020
@nishantwrp
Copy link
Contributor Author

nishantwrp commented Aug 12, 2020

@prasanna08 ptal!

Copy link
Contributor

@bansalnitish bansalnitish left a comment

LGTM from codeowner's perspective!

@bansalnitish bansalnitish removed their assignment Aug 14, 2020
Copy link
Contributor

@prasanna08 prasanna08 left a comment

LGTM for codeowner files

@nishantwrp nishantwrp merged commit 2d3aa66 into oppia:develop Aug 14, 2020
6 checks passed
@nishantwrp nishantwrp deleted the eslint-rules branch Aug 14, 2020
shavavo pushed a commit to shavavo/oppia that referenced this pull request Aug 20, 2020
* Introduce new eslint checks

* Fix typo

* Fix lint checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment