Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loads libraries in manifest.json using webpack, Add a seperate light module for karma #10223

Merged
merged 23 commits into from Aug 18, 2020
Merged

Loads libraries in manifest.json using webpack, Add a seperate light module for karma #10223

merged 23 commits into from Aug 18, 2020

Conversation

nishantwrp
Copy link
Contributor

@nishantwrp nishantwrp commented Aug 8, 2020

Overview

  1. This PR fixes or fixes part of #[fill_in_number_here].
  2. This PR does the following: Loads libraries in manifest.json using webpack

add a separate light module for karma

Currently karma used about-page.module.ts because there was one module needed. But the size of the bundle of that module in the webpack compilation was around (47mb) and this new module bundle size is around 300kb. so, this may slightly help with the compilation speed in the fe tests.

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

PR Pointers

  • Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays
  • Never force push. If you do, your PR will be closed.

@oppiabot
Copy link

oppiabot bot commented Aug 8, 2020

Hi, @nishantwrp, this pull request does not have a "CHANGELOG: ..." label as mentioned in the PR checkbox list. Please add this label. PRs without this label will not be merged. If you are unsure of which label to add, please ask the reviewers for guidance. Thanks!

@oppiabot
Copy link

oppiabot bot commented Aug 8, 2020

Assigning @vojtechjelinek for the first-pass review of this pull request. Thanks!

@nishantwrp nishantwrp changed the title Loads libraries in manifest.json using webpack Loads libraries in manifest.json using webpack, Add a seperate light module for karma Aug 8, 2020
@nishantwrp
Copy link
Contributor Author

nishantwrp commented Aug 15, 2020

Hey @nishantwrp Can you update the PR description, I dont understand the karma part from the title?(Sorry, I lack the context)
Also the thread looks like this.
image

I've updated the description.

@seanlip
Copy link
Member

seanlip commented Aug 16, 2020

Hi @nishantwrp, #10228 is merged. Maybe you could revise the estimates now?

@nishantwrp
Copy link
Contributor Author

nishantwrp commented Aug 16, 2020

Hi @seanlip,

There is a large improvement in times now.

Seeing this removed the timeout config from circleci config as well.

@nishantwrp nishantwrp assigned seanlip and U8NWXD and unassigned nishantwrp Aug 16, 2020
@nishantwrp nishantwrp removed the request for review from BenHenning Aug 16, 2020
Copy link
Member

@seanlip seanlip left a comment

Thanks! LGTM as codeowner.

@seanlip seanlip assigned jameesjohn and unassigned seanlip and Showtim3 Aug 17, 2020
U8NWXD
U8NWXD approved these changes Aug 17, 2020
Copy link
Member

@U8NWXD U8NWXD left a comment

@nishantwrp thanks for looking into the build times! I still don't understand how travis_wait works in those examples you linked to as it seems to contradict the documentation, but that's no longer an issue now that we don't need to change the timeouts

Copy link
Contributor

@jameesjohn jameesjohn left a comment

LGTM!
Thanks @nishantwrp

aks681
aks681 approved these changes Aug 17, 2020
Copy link
Member

@aks681 aks681 left a comment

Lgtm as codeowner.

@aks681 aks681 removed their assignment Aug 17, 2020
Copy link
Member

@vinitamurthi vinitamurthi left a comment

LGTM as codeowner

@vinitamurthi vinitamurthi removed their assignment Aug 18, 2020
@DubeySandeep DubeySandeep merged commit ba88470 into oppia:develop Aug 18, 2020
6 checks passed
@sainanee
Copy link
Contributor

sainanee commented Aug 18, 2020

This PR is causing issues with e2e tests
Screenshot 2020-08-18 at 9 15 35 PM

@nishantwrp
Copy link
Contributor Author

nishantwrp commented Aug 18, 2020

@orthodoxparadox you need to run yarn install first.

@U8NWXD
Copy link
Member

U8NWXD commented Aug 18, 2020

@nishantwrp the screenshot from @orthodoxparadox is from CircleCI, but yarn install seems like a solution to issues when running the tests locally, right? @orthodoxparadox I'm not seeing this issue when the tests run on develop, so I'm assuming you're seeing this issue on a PR? If so, try merging from develop

@nishantwrp nishantwrp deleted the manifest-libs branch Aug 18, 2020
shavavo pushed a commit to shavavo/oppia that referenced this pull request Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment