Fix lint checks failing on develop

[nishantwrp]

Overview

1. This PR fixes or fixes part of #[fill_in_number_here].
2. This PR does the following: Fix lint checks failing on develop

Essential Checklist

• The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• The linter/Karma presubmit checks have passed locally on your machine.
• "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
  • This lets reviewers restart your CircleCI tests for you.
• The PR is made from a branch that's not called "develop".

PR Pointers

• Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
• For what code owners will expect, see the Code Owner's wiki page.
• Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays
• Never force push. If you do, your PR will be closed.

[oppiabot]

Hi, @nishantwrp, this pull request does not have a "CHANGELOG: ..." label as mentioned in the PR checkbox list. Please add this label. PRs without this label will not be merged. If you are unsure of which label to add, please ask the reviewers for guidance. Thanks!

[oppiabot]

Assigning @vinitamurthi, @aks681 for the first pass review of this PR. Thanks!

[nishantwrp]

Hi @seanlip, can we merge this asap because the lint checks are failing on develop

[seanlip]

Thanks, LGTM.

@nishantwrp how did this breakage happen?

[seanlip]

Also @nishantwrp, next time, please could you provide the following info for this sort of PR?

• A link to the CI failure
• An explanation of why this occurred

That will save some back-and-forth to find out the details. Thanks!

[nishantwrp]

Actually, my pr that introduced the eslint checks passed the ci checks and it was being reviewed by the code owners but meanwhile, contributors added more instances of Array<t> in the codebase.

[seanlip]

Ah ok, makes sense. Can you link to the PR?

(In general, try to always provide links, refs, etc. for an audience who is not familiar with what you're talking about.)

[nishantwrp]

PR #10187