Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce more eslint checks #10377

Merged
merged 13 commits into from Aug 21, 2020
Merged

Introduce more eslint checks #10377

merged 13 commits into from Aug 21, 2020

Conversation

nishantwrp
Copy link
Contributor

@nishantwrp nishantwrp commented Aug 18, 2020

Overview

  1. This PR fixes or fixes part of #[fill_in_number_here].
  2. This PR does the following: Introduce more eslint checks

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

PR Pointers

  • Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays
  • Never force push. If you do, your PR will be closed.

@oppiabot
Copy link

oppiabot bot commented Aug 18, 2020

Hi, @nishantwrp, this pull request does not have a "CHANGELOG: ..." label as mentioned in the PR checkbox list. Please add this label. PRs without this label will not be merged. If you are unsure of which label to add, please ask the reviewers for guidance. Thanks!

@oppiabot
Copy link

oppiabot bot commented Aug 18, 2020

Assigning @DubeySandeep for the first-pass review of this pull request. Thanks!

Copy link
Member

@kevintab95 kevintab95 left a comment

LGTM for codeowner files. Thanks @nishantwrp!

@kevintab95 kevintab95 removed their assignment Aug 19, 2020
Copy link
Contributor

@jameesjohn jameesjohn left a comment

LGTM

Hudda
Hudda approved these changes Aug 19, 2020
@Hudda Hudda removed their assignment Aug 19, 2020
@jameesjohn jameesjohn removed their assignment Aug 19, 2020
Copy link
Contributor

@Showtim3 Showtim3 left a comment

LGTM
The "typed" code looks much better.Thanks for the PR!

@Showtim3 Showtim3 removed their assignment Aug 19, 2020
Copy link
Contributor

@bansalnitish bansalnitish left a comment

LGTM for codeowner files!

@bansalnitish bansalnitish removed their assignment Aug 20, 2020
Copy link
Contributor

@ankita240796 ankita240796 left a comment

LGTM for code-owner files, Thanks @nishantwrp!

@ankita240796 ankita240796 removed their assignment Aug 20, 2020
@DubeySandeep DubeySandeep removed their assignment Aug 20, 2020
@nishantwrp
Copy link
Contributor Author

nishantwrp commented Aug 20, 2020

Copy link
Member

@nithusha21 nithusha21 left a comment

LGTM for codeowner files

@nithusha21 nithusha21 removed their assignment Aug 21, 2020
aks681
aks681 approved these changes Aug 21, 2020
Copy link
Member

@aks681 aks681 left a comment

Lgtm as codeowner

@aks681 aks681 removed their assignment Aug 21, 2020
Copy link
Contributor

@prasanna08 prasanna08 left a comment

LGTM for CODEOWNER files

jimbyo
jimbyo approved these changes Aug 21, 2020
Copy link
Contributor

@jimbyo jimbyo left a comment

LGTM!(As codeowner) Just to let you know once #10152 merges the keyboard shortcut file will remove the setHref function.

@nishantwrp nishantwrp merged commit ce2fe41 into oppia:develop Aug 21, 2020
6 checks passed
@nishantwrp nishantwrp deleted the new-eslint-rules-1 branch Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment