Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more eslint checks #10414

Merged
merged 6 commits into from Aug 25, 2020
Merged

Add some more eslint checks #10414

merged 6 commits into from Aug 25, 2020

Conversation

nishantwrp
Copy link
Contributor

@nishantwrp nishantwrp commented Aug 22, 2020

Overview

  1. This PR fixes or fixes part of #[fill_in_number_here].
  2. This PR does the following: Add some more eslint checks

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

PR Pointers

  • Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays
  • Never force push. If you do, your PR will be closed.

@oppiabot
Copy link

oppiabot bot commented Aug 22, 2020

Assigning @bansalnitish, @Hudda for the first pass review of this PR. Thanks!

Copy link
Member

@vojtechjelinek vojtechjelinek left a comment

LGTM!

Hudda
Hudda approved these changes Aug 24, 2020
@Hudda Hudda removed their assignment Aug 24, 2020
@Showtim3
Copy link
Contributor

Showtim3 commented Aug 25, 2020

Merging this.

@Showtim3
Copy link
Contributor

Showtim3 commented Aug 25, 2020

Oh Sorry, seems like a review is pending from @bansalnitish

@vojtechjelinek
Copy link
Member

vojtechjelinek commented Aug 25, 2020

I think it is fine to merge this since the reviews work like OR so that one person should be enough.

@vojtechjelinek vojtechjelinek merged commit 6a64d48 into oppia:develop Aug 25, 2020
6 checks passed
@nishantwrp nishantwrp deleted the new-eslint-rules-2 branch Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants