Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6104: Use sub-process in pre_push_hook #6114

Merged
merged 2 commits into from Jan 14, 2019
Merged

Conversation

lilithxxx
Copy link
Contributor

@lilithxxx lilithxxx commented Jan 14, 2019

Explanation

Fixes #6104
Pre_push_hook now uses sub-process instead of gitpython to compare against remote

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR follows the style guide.
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue.

@codecov-io
Copy link

Codecov Report

Merging #6114 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6114   +/-   ##
========================================
  Coverage    45.32%   45.32%           
========================================
  Files          525      525           
  Lines        30861    30861           
  Branches      4614     4614           
========================================
  Hits         13989    13989           
  Misses       16872    16872

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71aeb18...86d4372. Read the comment docs.

Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing the third-party libs!

@seanlip seanlip merged commit b12f8e9 into oppia:develop Jan 14, 2019
@lilithxxx lilithxxx deleted the pre-push branch January 14, 2019 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove third-party libs added in PR #6033 and try using subprocess
3 participants