Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 1.4.2: Split ICustomScope to respective directives #9298

Merged
merged 2 commits into from May 15, 2020
Merged

Milestone 1.4.2: Split ICustomScope to respective directives #9298

merged 2 commits into from May 15, 2020

Conversation

nishantwrp
Copy link
Contributor

@nishantwrp nishantwrp commented May 12, 2020

Overview

1. This PR fixes or fixes part of #[fill_in_number_here].
2. This PR does the following: Split ICustomScope to respective directives

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

PR Pointers

  • Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays
  • Never force push. If you do, your PR will be closed.

@oppiabot
Copy link

oppiabot bot commented May 12, 2020

Hi, @nishantwrp. This pull request does not have a "CHANGELOG: ..." label as mentioned in the PR checkbox list. Please add this label. PRs without this label will not be merged. If you are unsure of which label to add, please ask the reviewers for guidance. Thanks!

@oppiabot
Copy link

oppiabot bot commented May 12, 2020

Assigning @kevinlee12 for the first-pass review of this pull request. Thanks!

@nishantwrp nishantwrp changed the title Split ICustomScope to respective directives Milestone 1.4.2: Split ICustomScope to respective directives May 12, 2020
Copy link
Contributor

@ankita240796 ankita240796 left a comment

LGTM for code-owner files, Thanks @nishantwrp!

@kevinlee12
Copy link
Contributor

kevinlee12 commented May 12, 2020

Hmm, the label doesn't look correct, should this be either in speed or angular migration?

@oppiabot
Copy link

oppiabot bot commented May 12, 2020

Assigning @bansalnitish for the first-pass review of this pull request. Thanks!

Copy link
Member

@vojtechjelinek vojtechjelinek left a comment

LGTM!

@vojtechjelinek
Copy link
Member

vojtechjelinek commented May 13, 2020

@kevintab95 @bansalnitish @aks681 PTAL

Copy link
Member

@kevintab95 kevintab95 left a comment

LGTM for code-owner files, thanks @nishantwrp!

@kevintab95 kevintab95 removed their assignment May 13, 2020
@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #9298 into develop will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #9298      +/-   ##
===========================================
+ Coverage    53.52%   53.55%   +0.03%     
===========================================
  Files          874      874              
  Lines        36275    36311      +36     
  Branches      4293     4303      +10     
===========================================
+ Hits         19416    19446      +30     
+ Misses       15913    15911       -2     
- Partials       946      954       +8     
Flag Coverage Δ
#frontend 53.55% <0.00%> (+0.03%) ⬆️
Impacted Files Coverage Δ
...nts/ck-editor-helpers/ck-editor-4-rte.directive.ts 4.88% <ø> (ø)
...ectives/common-elements/alert-message.directive.ts 9.09% <ø> (-7.58%) ⬇️
...tom-forms-directives/apply-validation.directive.ts 100.00% <ø> (ø)
...-forms-directives/audio-file-uploader.directive.ts 8.57% <ø> (ø)
...ustom-forms-directives/image-uploader.directive.ts 7.14% <ø> (ø)
...custom-forms-directives/object-editor.directive.ts 7.69% <ø> (ø)
...changes-editor/value-generator-editor.directive.ts 8.33% <ø> (ø)
...translation-bar/audio-translation-bar.directive.ts 6.21% <ø> (ø)
.../learner-experience/conversation-skin.directive.ts 10.49% <ø> (ø)
...s/oppia-interactive-music-notes-input.directive.ts 3.09% <0.00%> (ø)
... and 5 more

Copy link
Contributor

@kevinlee12 kevinlee12 left a comment

lgtm for code owner files.

@kevinlee12 kevinlee12 removed their assignment May 13, 2020
aks681
aks681 approved these changes May 13, 2020
Copy link
Member

@aks681 aks681 left a comment

Lgtm as codeowner

@aks681 aks681 removed their assignment May 13, 2020
@iamprayush
Copy link
Member

iamprayush commented May 14, 2020

@nishantwrp Please note the failing CI tests.

Copy link
Contributor

@bansalnitish bansalnitish left a comment

LGTM!

@bansalnitish bansalnitish removed their assignment May 15, 2020
@nishantwrp
Copy link
Contributor Author

nishantwrp commented May 15, 2020

@kevinlee12 We can merge this now?

@kevinlee12 kevinlee12 merged commit 81a781d into oppia:develop May 15, 2020
17 of 19 checks passed
@kevinlee12
Copy link
Contributor

kevinlee12 commented May 15, 2020

@nishantwrp nishantwrp deleted the custom-scope-types branch May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants