Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 1.4.3: Add type definitions for __fixtures__ #9307

Merged
merged 1 commit into from May 14, 2020
Merged

Milestone 1.4.3: Add type definitions for __fixtures__ #9307

merged 1 commit into from May 14, 2020

Conversation

nishantwrp
Copy link
Contributor

@nishantwrp nishantwrp commented May 13, 2020

Overview

1. This PR fixes or fixes part of #[fill_in_number_here].
2. This PR does the following: Add type definitions for fixtures

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

PR Pointers

  • Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays
  • Never force push. If you do, your PR will be closed.

@oppiabot
Copy link

oppiabot bot commented May 13, 2020

Hi, @nishantwrp. This pull request does not have a "CHANGELOG: ..." label as mentioned in the PR checkbox list. Please add this label. PRs without this label will not be merged. If you are unsure of which label to add, please ask the reviewers for guidance. Thanks!

@oppiabot
Copy link

oppiabot bot commented May 13, 2020

Assigning @bansalnitish for the first-pass review of this pull request. Thanks!

Copy link
Member

@vojtechjelinek vojtechjelinek left a comment

LGTM!

@nishantwrp nishantwrp assigned aks681 and unassigned vojtechjelinek May 13, 2020
Copy link
Contributor

@ankita240796 ankita240796 left a comment

LGTM for the type defs, Thanks @nishantwrp!

@ankita240796 ankita240796 removed their assignment May 13, 2020
@kevinlee12
Copy link
Contributor

kevinlee12 commented May 14, 2020

@nishantwrp please restart from failed here https://circleci.com/workflow-run/16f42302-64db-474a-b36b-9b4e2f833570

never mind, I was able to do it.

@kevinlee12 kevinlee12 merged commit 31a1eb6 into oppia:develop May 14, 2020
16 checks passed
@nishantwrp nishantwrp deleted the fixtures-any branch May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants