Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #7176: Remove any from some object factories - III #9370

Merged
merged 2 commits into from May 28, 2020
Merged

Fix part of #7176: Remove any from some object factories - III #9370

merged 2 commits into from May 28, 2020

Conversation

nishantwrp
Copy link
Contributor

@nishantwrp nishantwrp commented May 26, 2020

Overview

  1. This PR fixes or fixes part of Add types for Object Factories  #7176
  2. This PR does the following: Remove any from some object factories - III

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

PR Pointers

  • Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays
  • Never force push. If you do, your PR will be closed.

@oppiabot
Copy link

oppiabot bot commented May 26, 2020

Hi, @nishantwrp. This pull request does not have a "CHANGELOG: ..." label as mentioned in the PR checkbox list. Please add this label. PRs without this label will not be merged. If you are unsure of which label to add, please ask the reviewers for guidance. Thanks!

@oppiabot
Copy link

oppiabot bot commented May 26, 2020

Assigning @bansalnitish for the first-pass review of this pull request. Thanks!

Copy link
Member

@vojtechjelinek vojtechjelinek left a comment

LGTM!

@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #9370 into develop will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #9370   +/-   ##
========================================
  Coverage    54.07%   54.07%           
========================================
  Files          878      878           
  Lines        36394    36394           
  Branches      4357     4357           
========================================
  Hits         19677    19677           
  Misses       15722    15722           
  Partials       995      995           
Flag Coverage Δ
#frontend 54.07% <100.00%> (ø)
Impacted Files Coverage Δ
...mplates/domain/skill/MisconceptionObjectFactory.ts 100.00% <ø> (ø)
...ge/services/exploration-recommendations.service.ts 37.84% <ø> (ø)
...s/domain/collection/CollectionNodeObjectFactory.ts 84.85% <100.00%> (ø)
...lates/domain/collection/CollectionObjectFactory.ts 94.55% <100.00%> (ø)
...tes/domain/editor/undo_redo/ChangeObjectFactory.ts 100.00% <100.00%> (ø)

Copy link
Contributor

@marianadasilvadev marianadasilvadev left a comment

LGTM, thanks @nishantwrp

@oppiabot
Copy link

oppiabot bot commented May 27, 2020

Hi @nishantwrp. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

@kevinlee12
Copy link
Contributor

kevinlee12 commented May 27, 2020

Cancelled TravisCI due to merge conflicts.

Copy link
Member

@kevintab95 kevintab95 left a comment

LGTM, thanks @nishantwrp!

@kevintab95 kevintab95 removed their assignment May 27, 2020
@kevinlee12 kevinlee12 assigned nishantwrp and unassigned aks681 May 27, 2020
@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #9370 into develop will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #9370   +/-   ##
========================================
  Coverage    54.07%   54.07%           
========================================
  Files          878      878           
  Lines        36394    36394           
  Branches      4357     4357           
========================================
  Hits         19677    19677           
  Misses       15722    15722           
  Partials       995      995           
Flag Coverage Δ
#frontend 54.07% <100.00%> (ø)
Impacted Files Coverage Δ
...mplates/domain/skill/MisconceptionObjectFactory.ts 100.00% <ø> (ø)
...ge/services/exploration-recommendations.service.ts 37.84% <ø> (ø)
...s/domain/collection/CollectionNodeObjectFactory.ts 84.85% <100.00%> (ø)
...lates/domain/collection/CollectionObjectFactory.ts 94.55% <100.00%> (ø)
...tes/domain/editor/undo_redo/ChangeObjectFactory.ts 100.00% <100.00%> (ø)

@nishantwrp nishantwrp assigned kevinlee12 and unassigned nishantwrp May 27, 2020
@jameesjohn
Copy link
Contributor

jameesjohn commented May 27, 2020

PTAL @aks681.
Thanks.

aks681
aks681 approved these changes May 27, 2020
Copy link
Member

@aks681 aks681 left a comment

Just one qn, else lgm.

import { IMisconceptionBackendDict } from
'domain/skill/MisconceptionObjectFactory';

interface IBackendChangeObject {
Copy link
Member

@aks681 aks681 May 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you verified that all the new structures editors work as well?

Copy link
Contributor Author

@nishantwrp nishantwrp May 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there should be problems on the behaviour with just adding the types, as the code is transpiled to js anyway.

@aks681 aks681 assigned nishantwrp and unassigned aks681 May 27, 2020
@nishantwrp nishantwrp assigned aks681 and unassigned nishantwrp May 27, 2020
@kevinlee12 kevinlee12 merged commit a1fa806 into oppia:develop May 28, 2020
19 checks passed
@nishantwrp nishantwrp deleted the any-type-4 branch May 28, 2020
shavavo pushed a commit to shavavo/oppia that referenced this pull request Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants