Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #7165: Add WARNING_TYPE to interaction validation spec files #9371

Merged
merged 1 commit into from May 27, 2020
Merged

Fix part of #7165: Add WARNING_TYPE to interaction validation spec files #9371

merged 1 commit into from May 27, 2020

Conversation

nishantwrp
Copy link
Contributor

@nishantwrp nishantwrp commented May 26, 2020

Overview

  1. This PR fixes or fixes part of Eliminate 'any' type in favor of its exact type. #7165 .
  2. This PR does the following: Add WARNING_TYPE to interaction validation spec files

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

PR Pointers

  • Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays
  • Never force push. If you do, your PR will be closed.

@oppiabot
Copy link

oppiabot bot commented May 26, 2020

Assigning @bansalnitish for the first-pass review of this pull request. Thanks!

@nishantwrp nishantwrp changed the title Fix part of #7175: Add WARNING_TYPE to interaction validation spec files Fix part of #7165: Add WARNING_TYPE to interaction validation spec files May 26, 2020
Copy link
Contributor

@marianadasilvadev marianadasilvadev left a comment

LGTM as codeowner!

@marianadasilvadev marianadasilvadev removed their assignment May 26, 2020
Copy link
Member

@vojtechjelinek vojtechjelinek left a comment

LGTM!

@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #9371 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #9371   +/-   ##
========================================
  Coverage    54.07%   54.07%           
========================================
  Files          878      878           
  Lines        36394    36394           
  Branches      4357     4357           
========================================
  Hits         19677    19677           
  Misses       15722    15722           
  Partials       995      995           
Flag Coverage Δ
#frontend 54.07% <ø> (ø)

@kevinlee12 kevinlee12 merged commit 7439c1f into oppia:develop May 27, 2020
19 checks passed
@nishantwrp nishantwrp deleted the any-type-5 branch May 27, 2020
shavavo pushed a commit to shavavo/oppia that referenced this pull request Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants