Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #7165: Remove some more any types #9754

Merged
merged 3 commits into from Jul 4, 2020
Merged

Fix part of #7165: Remove some more any types #9754

merged 3 commits into from Jul 4, 2020

Conversation

nishantwrp
Copy link
Contributor

@nishantwrp nishantwrp commented Jul 1, 2020

Overview

  1. This PR fixes or fixes part of Eliminate 'any' type in favor of its exact type. #7165
  2. This PR does the following: Remove some more any types

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

PR Pointers

  • Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays
  • Never force push. If you do, your PR will be closed.

@oppiabot
Copy link

oppiabot bot commented Jul 1, 2020

Hi, @nishantwrp. This pull request does not have a "CHANGELOG: ..." label as mentioned in the PR checkbox list. Please add this label. PRs without this label will not be merged. If you are unsure of which label to add, please ask the reviewers for guidance. Thanks!

@oppiabot
Copy link

oppiabot bot commented Jul 1, 2020

Assigning @bansalnitish for the first-pass review of this pull request. Thanks!

import { StatePropertyService } from
// eslint-disable-next-line max-len
'components/state-editor/state-editor-properties-services/state-property.service';
Copy link
Contributor Author

@nishantwrp nishantwrp Jul 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it from here because it should not be used directly but should be inherited first.

Copy link
Member

@vojtechjelinek vojtechjelinek left a comment

LGTM!

Copy link
Member

@kevintab95 kevintab95 left a comment

LGTM for codeowner files. Thanks @nishantwrp!

@kevintab95 kevintab95 removed their assignment Jul 2, 2020
Copy link
Contributor

@brianrodri brianrodri left a comment

LGTM for codeowner files!

aks681
aks681 approved these changes Jul 2, 2020
Copy link
Member

@aks681 aks681 left a comment

Lgtm as codeowner

@aks681 aks681 removed their assignment Jul 2, 2020
@nishantwrp
Copy link
Contributor Author

nishantwrp commented Jul 2, 2020

Copy link
Contributor

@bansalnitish bansalnitish left a comment

LGTM for codeowner files

@bansalnitish bansalnitish removed their assignment Jul 3, 2020
@prasanna08
Copy link
Contributor

prasanna08 commented Jul 3, 2020

LGTM for codeowner files.

@prasanna08 prasanna08 removed their assignment Jul 3, 2020
Copy link
Member

@srijanreddy98 srijanreddy98 left a comment

LGTM for code owner files!

@oppiabot
Copy link

oppiabot bot commented Jul 3, 2020

Hi @nishantwrp. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

@nishantwrp
Copy link
Contributor Author

nishantwrp commented Jul 3, 2020

@nithusha21 ptal!

@nithusha21 nithusha21 merged commit 8bfd1fc into oppia:develop Jul 4, 2020
6 checks passed
@nishantwrp nishantwrp deleted the any-type-12 branch Jul 4, 2020
shavavo pushed a commit to shavavo/oppia that referenced this pull request Aug 20, 2020
* Remove some more any types

* Fix FE tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants