Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade version of wavesurfer and use type defs from DefinitelyTyped #9831

Merged
merged 2 commits into from Jul 9, 2020
Merged

Upgrade version of wavesurfer and use type defs from DefinitelyTyped #9831

merged 2 commits into from Jul 9, 2020

Conversation

nishantwrp
Copy link
Contributor

@nishantwrp nishantwrp commented Jul 7, 2020

Overview

  1. This PR fixes or fixes part of NA
  2. This PR does the following: Upgrade version of wavesurfer and use type defs from DefinitelyTyped

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

PR Pointers

  • Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays
  • Never force push. If you do, your PR will be closed.

@oppiabot
Copy link

oppiabot bot commented Jul 7, 2020

Hi, @nishantwrp, this pull request does not have a "CHANGELOG: ..." label as mentioned in the PR checkbox list. Please add this label. PRs without this label will not be merged. If you are unsure of which label to add, please ask the reviewers for guidance. Thanks!

@oppiabot
Copy link

oppiabot bot commented Jul 7, 2020

Assigning @kevinlee12 for the first-pass review of this pull request. Thanks!

@nishantwrp
Copy link
Contributor Author

nishantwrp commented Jul 7, 2020

Copy link
Member

@vojtechjelinek vojtechjelinek left a comment

LGTM!

Copy link
Member

@DubeySandeep DubeySandeep left a comment

LGTM! :)

@DubeySandeep DubeySandeep removed their assignment Jul 7, 2020
Hudda
Hudda approved these changes Jul 8, 2020
Copy link
Member

@Hudda Hudda left a comment

LGTM

@nishantwrp
Copy link
Contributor Author

nishantwrp commented Jul 8, 2020

@ankita240796 ptal!

Copy link
Contributor

@ankita240796 ankita240796 left a comment

LGTM for typings, Thanks @nishantwrp!

@ankita240796 ankita240796 removed their assignment Jul 9, 2020
@vojtechjelinek vojtechjelinek merged commit 804751e into oppia:develop Jul 9, 2020
6 checks passed
@nishantwrp nishantwrp deleted the wavesurfer-upgrade branch Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants