/opps

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix json field #452

Closed
wants to merge 2 commits into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@lucassimon @jeanmask @lerrua
@lucassimon

lucassimon added some commits Feb 24, 2015

@lucassimon
Set all value parameter to default a empty dict 
This is used to this variable assumes a empty value dict intead of
NoneType object or empty strings
9fe2fd8
@lucassimon
Do a condition thats check the object and value 
Firstly checks if the object is not none or empty string.
The same validation will use when check if the value is a type string
and it is a different of unicode empty string
cfeb3e4
@jeanmask

This comment has been minimized.

Show comment
Hide comment
@jeanmask

jeanmask Feb 26, 2015

Member

This is not correct way to solve this problem. You change arguments positions and define default values, see this: https://docs.djangoproject.com/en/1.5/howto/custom-model-fields/
Member

jeanmask commented Feb 26, 2015

This is not correct way to solve this problem. You change arguments positions and define default values, see this: https://docs.djangoproject.com/en/1.5/howto/custom-model-fields/

@lerrua lerrua closed this May 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment