Visibility into total applications configured with Opro #33

Merged
merged 3 commits into from Feb 7, 2014

Projects

None yet

2 participants

@texasjusticar
Contributor

A situation arose where myself and a co-worker were setting up an account server using Opro. He had created our application using his user, and we spent more time than I care to admit trying to understand why I couldn't see the secret/key when I was logged in.

For cases where you have multiple administrators for potentially multiple applications, I felt this simple addition would be beneficial to those administrators. Whether this should be expanded so that multiple users can actually administer those applications I didn't attempt to solve. But with this change other administrators will at least know the applications do exist. If they have the authorization they should be able to access the db or console to find the information they need.

@schneems
Contributor

This is a risky change. When you view your applications on github.com or heroku.com it doesn't say, "you have 3 applications" and there are "1,000,000,something total applications" on the whole system. I can imagine quite a few app owners not wanting that information to be public. Maybe we can add some extra text to the readme or to the example app to help solve this problem?

@texasjusticar
Contributor

Fair enough about obfuscating the data. Maybe rather than showing the count in both cases we simply show a "Detecting Applications Installed" if your user has none to indicate the table isn't empty? Also updating the readme to remind people the application is tied to the user would be good. It would be nice to include something in the interface itself if at all possible.

Thanks for taking a look.

@schneems
Contributor

How about if the table is empty add the prompt "Maybe you created an
application under a different user account?" and then add a link "create a
new application"

On Thu, Jul 18, 2013 at 1:26 PM, Ethan Burrow notifications@github.comwrote:

Fair enough about obfuscating the data. Maybe rather than showing the
count in both cases we simply show a "Detecting Applications Installed" if
your user has none to indicate the table isn't empty? Also updating the
readme to remind people the application is tied to the user would be good.
It would be nice to include something in the interface itself if at all
possible.

Thanks for taking a look.


Reply to this email directly or view it on GitHubhttps://github.com/opro/opro/pull/33#issuecomment-21204094
.

@texasjusticar
Contributor

That sounds good, I'll update my pull request and update the readme as well.

@texasjusticar texasjusticar updating readme and oauth_docs to include information regarding clien…
…t_app associated to user creating it, update oauth_client_app view to only print note to user if they have no applications and others exist, update tests to reflect changes to view template - also adding an assertion in the correct user to ensure warning does not show up for users with existing applications
e0e22d8
@schneems
Contributor
schneems commented Feb 7, 2014

This one slipped through the cracks, going to merge in. Thanks for the help ❤️

@schneems schneems merged commit 9fbd0bb into opro:master Feb 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment