Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve client.rb file parsing #1940

Closed
mffrench opened this issue Aug 27, 2014 · 5 comments
Closed

Improve client.rb file parsing #1940

mffrench opened this issue Aug 27, 2014 · 5 comments
Labels
Type: Bug Does not work as expected.

Comments

@mffrench
Copy link

Hello,

you can remove a billion dollar mistake (ie: a nill exception ;)) by raising a badly formated URL error while parsing the server url in the client.rb file.

Full context of this improvment request can be found on this thread :

http://lists.opscode.com/sympa/arc/chef/2014-08/msg00328.html
http://lists.opscode.com/sympa/arc/chef/2014-08/msg00329.html

Regards,

Mathilde

@sersut
Copy link
Contributor

sersut commented Sep 2, 2014

Thanks for filing this @mffrench. To summarize my understanding of the attached issue, we would like to raise an error if we have a badly formatted URI for server. Is my understanding right @mffrench

@mffrench
Copy link
Author

mffrench commented Sep 6, 2014

Hello @sersut,

yep your understanding is right !

Thank you

@rekhajoshm
Copy link

patch attached.thanks.

@lamont-granquist lamont-granquist added this to the Help Wanted milestone Apr 22, 2015
@thommay thommay added Type: Bug Does not work as expected. and removed Bug labels Jan 25, 2017
@lamont-granquist
Copy link
Contributor

closing due to lack of interest in fixing the PR

@lock
Copy link

lock bot commented May 17, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Bug Does not work as expected.
Projects
None yet
Development

No branches or pull requests

5 participants