[FIX] Rescue correct exception when "node.fqdn" is not defined#201
[FIX] Rescue correct exception when "node.fqdn" is not defined#201karmi wants to merge 1 commit into
Conversation
When `node.fqdn` is not defined, the exception raised is "ArgumentError" (`Attribute fqdn is not defined`). Should probably use `node.hostname` when `node.fqdn` is undefined.
|
Thank you for supporting Chef! Our process has a couple prerequisites before we can merge your contribution. We need to ensure you've completed a Contributor License Agreement (CLA) and a ticket on our ticket tracker for the release workflow. Please take a moment to review the below wiki page for the appropriate steps: This ticket appears relevant to your patch: http://tickets.opscode.com/browse/CHEF-1645 |
|
Hi Bryan, sure, I'll check it out. |
|
Bryan, filed the http://tickets.opscode.com/browse/CHEF-2796 ticket, is there anything more I have to do? |
|
You will need to complete the Contributor License Agreement as described in step two of the how to contribute page. This is important for protecting the users of Chef from potential copyright lawsuits and contribution retractions. http://wiki.opscode.com/display/chef/How+to+Contribute#HowtoContribute-WhydoIneedtofilloutaCLA%3F |
|
Yeah, I did that already, no problems with that. Now, should I send the PDF somewhere or...? Sorry :) |
|
No problem! Once you complete the CLA it will probably take a couple days to be processed. You'll get a confirmation email from Opscode. Then you'll have access on JIRA to "resolve" the ticket, which will show that it is all set for Opscode to review the patch for merging. |
|
Hi, yes, the paperwork arrived, "resolved" the ticket at http://tickets.opscode.com/browse/CHEF-2796 |
|
Thanks Karel, merged to master! |
|
Thanks, Bryan! |
When
node.fqdnis not defined, the exception raised is "ArgumentError" (Attribute fqdn is not defined).Should probably use
node.hostnamewhennode.fqdnis undefined, in the end.