Skip to content

[FIX] Rescue correct exception when "node.fqdn" is not defined#201

Closed
karmi wants to merge 1 commit into
chef:masterfrom
karmi:fix_fqdn_exception
Closed

[FIX] Rescue correct exception when "node.fqdn" is not defined#201
karmi wants to merge 1 commit into
chef:masterfrom
karmi:fix_fqdn_exception

Conversation

@karmi

@karmi karmi commented Dec 11, 2011

Copy link
Copy Markdown
Contributor

When node.fqdn is not defined, the exception raised is "ArgumentError" (Attribute fqdn is not defined).

Should probably use node.hostname when node.fqdn is undefined, in the end.

When `node.fqdn` is not defined, the exception raised is "ArgumentError" (`Attribute fqdn is not defined`).

Should probably use `node.hostname` when `node.fqdn` is undefined.
@btm

btm commented Dec 11, 2011

Copy link
Copy Markdown
Contributor

Thank you for supporting Chef! Our process has a couple prerequisites before we can merge your contribution. We need to ensure you've completed a Contributor License Agreement (CLA) and a ticket on our ticket tracker for the release workflow. Please take a moment to review the below wiki page for the appropriate steps:
 
http://wiki.opscode.com/display/chef/How+to+Contribute

This ticket appears relevant to your patch: http://tickets.opscode.com/browse/CHEF-1645

@karmi

karmi commented Dec 11, 2011

Copy link
Copy Markdown
Contributor Author

Hi Bryan, sure, I'll check it out.

@karmi

karmi commented Dec 11, 2011

Copy link
Copy Markdown
Contributor Author

Bryan, filed the http://tickets.opscode.com/browse/CHEF-2796 ticket, is there anything more I have to do?

@btm

btm commented Dec 11, 2011

Copy link
Copy Markdown
Contributor

You will need to complete the Contributor License Agreement as described in step two of the how to contribute page.

This is important for protecting the users of Chef from potential copyright lawsuits and contribution retractions.

http://wiki.opscode.com/display/chef/How+to+Contribute#HowtoContribute-WhydoIneedtofilloutaCLA%3F

@karmi

karmi commented Dec 11, 2011

Copy link
Copy Markdown
Contributor Author

Yeah, I did that already, no problems with that. Now, should I send the PDF somewhere or...? Sorry :)

@btm

btm commented Dec 13, 2011

Copy link
Copy Markdown
Contributor

No problem! Once you complete the CLA it will probably take a couple days to be processed. You'll get a confirmation email from Opscode. Then you'll have access on JIRA to "resolve" the ticket, which will show that it is all set for Opscode to review the patch for merging.

@karmi

karmi commented Dec 13, 2011

Copy link
Copy Markdown
Contributor Author

Hi, yes, the paperwork arrived, "resolved" the ticket at http://tickets.opscode.com/browse/CHEF-2796

@btm

btm commented Feb 9, 2012

Copy link
Copy Markdown
Contributor

Thanks Karel, merged to master!

@btm btm closed this Feb 9, 2012
@karmi

karmi commented Feb 10, 2012

Copy link
Copy Markdown
Contributor Author

Thanks, Bryan!

@chef chef locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants