Skip to content

[CHEF-3364] Fix up Smartos Package provider#577

Closed
sawanoboly wants to merge 2 commits into
chef:masterfrom
higanworks:CHEF-3364-fix_up_smartos_with_spec
Closed

[CHEF-3364] Fix up Smartos Package provider#577
sawanoboly wants to merge 2 commits into
chef:masterfrom
higanworks:CHEF-3364-fix_up_smartos_with_spec

Conversation

@sawanoboly

Copy link
Copy Markdown
Contributor

I fixed up spec file for pull request #446

This request includes fixed code for smartos package provider and spec.

@wohali

wohali commented Mar 26, 2013

Copy link
Copy Markdown

There seem to be a lot of whitespace-only changes here, can these be revreted? It makes it hard to review the actual changes being made.

@cphrmky

cphrmky commented Mar 26, 2013

Copy link
Copy Markdown

add ?w=1 and the whitespace won't show up

On Tue, Mar 26, 2013 at 1:48 PM, Joan Touzet notifications@github.comwrote:

There seem to be a lot of whitespace-only changes here, can these be
revreted? It makes it hard to review the actual changes being made.


Reply to this email directly or view it on GitHubhttps://github.com//pull/577#issuecomment-15487569
.

@wohali

wohali commented Mar 26, 2013

Copy link
Copy Markdown

Thanks, never had to do that before.

An additional test case to show that installing packages without explicit version numbers would be appreciated; in the current provider, the bare entry package "foobar" fails.

@btm

btm commented Apr 11, 2013

Copy link
Copy Markdown
Contributor

Merged to master.

@btm btm closed this Apr 11, 2013
@chef chef locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants