[CHEF-3237] Fix Mac OS X service provider. Do not fail when HOME is not set#624
Closed
iafonov wants to merge 1 commit into
Closed
[CHEF-3237] Fix Mac OS X service provider. Do not fail when HOME is not set#624iafonov wants to merge 1 commit into
iafonov wants to merge 1 commit into
Conversation
…ot set * Do not add `~/Library/LaunchAgents` if HOME is not set * It is safe to assume that if HOME is not set ~ will not expand - see rb_home_dir function in MRI ruby
Contributor
|
Fixed by #767 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://tickets.opscode.com/browse/CHEF-3237
Fix Mac OS X service provider. Do not fail when HOME is not set
~/Library/LaunchAgentsif HOME is not setNB: It is unclear from the diff but there is not so much changes to file, I've extracted a separate isolated context from existing tests and added a separate context for method that gathers plist dirs. You can see it here - https://github.com/iafonov/chef/blob/20ff8e5a508fad1823809c4e3988c579e05e7d4c/spec/unit/provider/service/macosx_spec.rb#L22