add support for reading key from remote url#77
Merged
Conversation
Contributor
|
I merged this in 52ab7df which also includes a bit of refactoring, some tests, and a fix on top. Note: s[-1] == "\n" is not what you think. |
lamont-granquist
added a commit
that referenced
this pull request
Sep 30, 2015
fixes for omnibus-ruby 1.1.0
srenatus
pushed a commit
to srenatus/chef
that referenced
this pull request
Apr 5, 2016
fix the issue76 missing version from the cookbook delete path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for reading encryption keys from a remote url (similar to my existing cookbook). Not sure how you wanted to handle error so I made something up as argument errors. Also didn't see any functional tests for the encryption stuff so I just ran the existing spec. Here's a sample session output: