Skip to content

Fixed CHEF-2279 - accept list of ephemeral block devices when creating an#2

Closed
kindkid wants to merge 1 commit into
chef:masterfrom
rmm:CHEF-2279
Closed

Fixed CHEF-2279 - accept list of ephemeral block devices when creating an#2
kindkid wants to merge 1 commit into
chef:masterfrom
rmm:CHEF-2279

Conversation

@kindkid

@kindkid kindkid commented Apr 27, 2011

Copy link
Copy Markdown

Fixed CHEF-2279 - accept list of ephemeral block devices when creating an ec2 server.

@shuangwu

Copy link
Copy Markdown

I'd love to see this fix merged into master, have been waiting for it since May.

@georgekola

Copy link
Copy Markdown

I would like to see this fix merged into master.

@georgekola

Copy link
Copy Markdown

Never mind. The above fix is not needed. The functionality can be achieved by using --user-data=<file_name> argument to 'knife ec2 server create' and having the block device list mapping contained in this file.

@luisbosque

Copy link
Copy Markdown

@georgekola how that functionality is supposed to be achieved with --user-data? neither knife or fog don't look for device block mappings in the user-data

@georgekola

Copy link
Copy Markdown

I use this. Just add the block mapping to the file and it works. You can check the code for user data, all the file data is passed to fog

@luisbosque

Copy link
Copy Markdown

Which format should I use to pass this data through the user data? A ruby hash, like:
{"BlockDeviceMapping.1.VirtualName"=>"ephemeral0", "BlockDeviceMapping.1.DeviceName"=>"/dev/sdb", "BlockDeviceMapping.2.VirtualName"=>"ephemeral1", "BlockDeviceMapping.2.DeviceName"=>"/dev/sdc"}

Or GET parameters data like:
&BlockDeviceMapping.1.VirtualName=ephemeral0
&BlockDeviceMapping.1.DeviceName=/dev/sdb
&BlockDeviceMapping.2.VirtualName=ephemeral1
&BlockDeviceMapping.2.DeviceName=/dev/sdc

Or XML format?

Could you show a example of the user data file with block device mappings in it? I can't find where fog looks for block device mappings in the user data.

Thanks

@jordandm

jordandm commented Mar 9, 2012

Copy link
Copy Markdown

This pull should be merged into master as soon as possible.

In addition, we need to go over knife-ec2 and make it able to do everything you can do with ec2-run-instances (http://docs.amazonwebservices.com/AWSEC2/latest/CommandLineReference/ApiReference-cmd-RunInstances.html). There is a lot of functionality missing here.

If someone is going to propose a workaround, then they should clearly document what is involved in setting it up to work. Others have mentioned the user-data option to me and I have spent - like others above - literally hours looking at it and trying to figure out how to do it.

I am now up against a wall here and I need to get ephemeral storage working on our EBS backed EC2 instances. I am going to have to merge this myself and start running a "non-standard" ec2-knife.

@stevendanna

Copy link
Copy Markdown
Contributor

Hi all,

Sorry for the long delay on this pull request. I left a comment on the related ticket with an update:

http://tickets.opscode.com/browse/KNIFE_EC2-28

If we can get some tests added for this feature I can help move it along our process. We are working to have more frequent releases of these plugins and hopefully delays like this won't happen as often in the future.

Cheers,

Steven

@kindkid

kindkid commented Jun 7, 2012

Copy link
Copy Markdown
Author

Hi, I'm a bit busy for the next week or so. If anyone wants to take this and run with it, I'd be grateful.

scottbessler referenced this pull request in scottbessler/knife-ec2 Aug 21, 2012
fix ephemeral, dont think it works from knife.rb yet
@tomdz

tomdz commented Sep 6, 2012

Copy link
Copy Markdown
Contributor

Could somebody please merge this ? It's quite painful otherwise to use ephemeral storage with chef/knife.

@stevendanna

Copy link
Copy Markdown
Contributor

As mentioned in KNIFE_EC2-28 we are currently waiting on tests for this. Once we get tests, it will get marked for merge.

@tomdz

tomdz commented Sep 7, 2012

Copy link
Copy Markdown
Contributor

I created an updated version of this pull request with tests: #80

@stevendanna

Copy link
Copy Markdown
Contributor

Github didn't close this since I did some conflict resolution but this has been merged here: fe8e25d

Thanks to everyone who contributed to get this feature in master!

@stevendanna stevendanna closed this Sep 8, 2012
adamedx pushed a commit that referenced this pull request Jan 28, 2014
…customization

OC- 11118 color customization
mwalton236 pushed a commit to mwalton236/knife-ec2 that referenced this pull request Oct 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants