Skip to content

Conversation

@jpluta
Copy link
Contributor

@jpluta jpluta commented Mar 21, 2024

What changes does your PR bring?

Refreshed codebase.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (non-breaking change to the build process or auxiliary tools)
  • New feature (non-breaking change which adds functionality)
  • Documentation (Improvements or additions to documentation)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

References

Fixes:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jpluta jpluta requested a review from a team as a code owner March 21, 2024 14:13
Copy link
Contributor

@michaltomczuk michaltomczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think we should delete the branch after merging.

@jpluta jpluta merged commit 68b7f03 into main Mar 26, 2024
@jpluta jpluta deleted the 5-github-module branch March 26, 2024 13:45
@michaltomczuk michaltomczuk added the enhancement New feature or request label Mar 26, 2024
@jpluta jpluta linked an issue Apr 11, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Github module

3 participants