Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of Arithmetic overflow on Perf Counters #370

Merged
merged 1 commit into from Mar 18, 2020

Conversation

@tarynpratt
Copy link
Contributor

tarynpratt commented Mar 18, 2020

If the perf counters for a server get too large, the query begins to throw an issue with an arithmetic overflow. Most specifically it throws an error:

Unable to fetch from SQL: Arithmetic overflow error converting expression to data type money.

Instead of converting to money, this converts the value to a decimal(25,2) which at least covers my use case.

Copy link
Member

NickCraver left a comment

Looks good - thanks!

@NickCraver NickCraver merged commit 5bff872 into opserver:master Mar 18, 2020
2 checks passed
2 checks passed
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.