-
Notifications
You must be signed in to change notification settings - Fork 6
Merge stable into develop #605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ching relationships" This reverts commit de6cfbf.
It would make clients hang when using batches within batches. Signed-off-by: Fatih Acar <fatih@opsmill.com>
WalkthroughThe changes refactor the concurrent execution control mechanism in the Infrahub SDK. The async client no longer instantiates a semaphore for concurrent execution limits. Instead, the Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🧰 Additional context used📓 Path-based instructions (2)**/*.py📄 CodeRabbit inference engine (CLAUDE.md)
Files:
infrahub_sdk/client.py📄 CodeRabbit inference engine (CLAUDE.md)
Files:
🧠 Learnings (1)📚 Learning: 2025-08-24T13:35:12.998ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying infrahub-sdk-python with
|
| Latest commit: |
7b0e10d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5a349c40.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://fac-merge-stable-into-develo.infrahub-sdk-python.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## develop #605 +/- ##
===========================================
- Coverage 76.44% 75.42% -1.02%
===========================================
Files 112 108 -4
Lines 10856 9323 -1533
Branches 2335 1855 -480
===========================================
- Hits 8299 7032 -1267
+ Misses 1982 1802 -180
+ Partials 575 489 -86
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 21 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary by CodeRabbit
create_batch()now an async method.max_concurrent_executionparameter.