Skip to content

Conversation

@ajtmccarty
Copy link
Contributor

@ajtmccarty ajtmccarty commented Oct 3, 2024

IFC-753

Various fixes following the last round of diff updates

  • use branched_from instead of created_at for diff calculation b/c branched_from is updated following a merge or rebase
  • clean up how we do diff recalculation following changes to how we store the diffs in 0.16.2
  • remove unchanged values from the calculated diff
  • fix an error I found by chance in relationship deletes where we would create OWNER and SOURCE edges in the database instead of HAS_OWNER and HAS_SOURCE
  • fix the diff rebase tests to look for the correct data (no conflicts after a rebase)
  • updates to the DiffAllPathsQuery
    • to ignore nodes/attributes/relationships added and deleted within the diff timeframe
    • remove a few filters that prevented correctly handling deleted relationships within a deleted node
    • move the logic to gather previous values and peer IDs to the end of the query, hopefully split this out into its own separate query

@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Oct 3, 2024
@ajtmccarty ajtmccarty marked this pull request as ready for review October 4, 2024 02:47
@ajtmccarty ajtmccarty requested a review from a team October 4, 2024 02:48
@ajtmccarty ajtmccarty merged commit 01e37a6 into stable Oct 4, 2024
31 checks passed
@ajtmccarty ajtmccarty deleted the ajtm-10012024-diff-deletes branch October 4, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

group/backend Issue related to the backend (API Server, Git Agent)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants