Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mima settings #1180

Merged
merged 2 commits into from Jul 30, 2021
Merged

update mima settings #1180

merged 2 commits into from Jul 30, 2021

Conversation

julien-truffaut
Copy link
Member

I am only getting one error when I run mima locally. It seems to be related to platform specific string.

[error] macros: Failed binary compatibility check against dev.optics:monocle-macro_2.13:3.0.0! Found 2 potential problems
[error]  * static method stringToURL()monocle.PPrism in class monocle.Monocle does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("monocle.Monocle.stringToURL")
[error]  * method stringToURL()monocle.PPrism in object monocle.Monocle does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("monocle.Monocle.stringToURL")
[error] core: Failed binary compatibility check against dev.optics:monocle-core_2.13:3.0.0! Found 4 potential problems
[error]  * static method stringToURL()monocle.PPrism in class monocle.std.all does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("monocle.std.all.stringToURL")
[error]  * method stringToURL()monocle.PPrism in object monocle.std.all does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("monocle.std.all.stringToURL")
[error]  * static method stringToURL()monocle.PPrism in class monocle.std.string does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("monocle.std.string.stringToURL")
[error]  * method stringToURL()monocle.PPrism in object monocle.std.string does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("monocle.std.string.stringToURL")

Copy link
Collaborator

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julien-truffaut julien-truffaut merged commit 1f2f53e into master Jul 30, 2021
@julien-truffaut julien-truffaut deleted the mima-update branch July 30, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants