Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix to support android-12+ #400

Merged
merged 7 commits into from Apr 1, 2022
Merged

chore: fix to support android-12+ #400

merged 7 commits into from Apr 1, 2022

Conversation

jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Jan 18, 2022 •
edited

Summary

Fix for android 12+ support (app crashes with PendingIntent flag requirement when built with targetSdkVersion=31)

  • upgrade dependency "androidx.work:work-runtime" to 2.7.1
  • add "android:exported" to test-app activities
  • upgrade compileSDKVersion/targetSDKVersion to 32

Test plan

  • Build/run test-app with Android OS 31 and 32

Issues

  • OASIS-8137

@jaeopt jaeopt requested a review from a team as a code owner January 18, 2022 23:35
@jaeopt jaeopt removed their assignment Jan 24, 2022
msohailhussain
msohailhussain approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jaeopt jaeopt mentioned this pull request Mar 10, 2022
Closed
@jaeopt jaeopt mentioned this pull request Mar 23, 2022
Merged
@jaeopt jaeopt closed this Apr 1, 2022
@jaeopt jaeopt reopened this Apr 1, 2022
@jaeopt jaeopt merged commit 7575bad into master Apr 1, 2022
@jaeopt jaeopt deleted the jae/sdk31 branch April 1, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msohailhussain msohailhussain msohailhussain approved these changes

Assignees

@jaeopt jaeopt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jaeopt @msohailhussain @optimizely-codereview-bot