From 6eb52ff79454c97f7731ef226408c3af921c4c1a Mon Sep 17 00:00:00 2001 From: Thomas Zurkan Date: Mon, 26 Nov 2018 12:54:31 -0800 Subject: [PATCH] have the buffer reader call wrapped in a try catch in case of exception --- .../ab/event/internal/BuildVersionInfo.java | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/core-api/src/main/java/com/optimizely/ab/event/internal/BuildVersionInfo.java b/core-api/src/main/java/com/optimizely/ab/event/internal/BuildVersionInfo.java index b600dd763..97e652399 100644 --- a/core-api/src/main/java/com/optimizely/ab/event/internal/BuildVersionInfo.java +++ b/core-api/src/main/java/com/optimizely/ab/event/internal/BuildVersionInfo.java @@ -37,18 +37,22 @@ public final class BuildVersionInfo { public final static String VERSION = readVersionNumber(); private static String readVersionNumber() { - BufferedReader bufferedReader = - new BufferedReader( - new InputStreamReader(BuildVersionInfo.class.getResourceAsStream("/optimizely-build-version"), - Charset.forName("UTF-8"))); + BufferedReader bufferedReader = null; try { + bufferedReader = + new BufferedReader( + new InputStreamReader(BuildVersionInfo.class.getResourceAsStream("/optimizely-build-version"), + Charset.forName("UTF-8"))); + return bufferedReader.readLine(); } catch (Exception e) { logger.error("unable to read version number"); return "unknown"; } finally { try { - bufferedReader.close(); + if (bufferedReader != null) { + bufferedReader.close(); + } } catch (Exception e) { logger.error("unable to close reader cleanly"); }