From 6c48b4b20df784c798b8f70a8de7499dbc6833bf Mon Sep 17 00:00:00 2001 From: Florian McKee Date: Fri, 9 Sep 2022 09:15:15 -0500 Subject: [PATCH] POC: HTTP-level errors are not logged properly --- packages/datafile-manager/src/nodeRequest.ts | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/packages/datafile-manager/src/nodeRequest.ts b/packages/datafile-manager/src/nodeRequest.ts index 939bac536..a519b95bd 100644 --- a/packages/datafile-manager/src/nodeRequest.ts +++ b/packages/datafile-manager/src/nodeRequest.ts @@ -93,11 +93,19 @@ function getResponseFromRequest(request: http.ClientRequest): Promise clearTimeout(timeout); - resolve({ - statusCode: incomingMessage.statusCode, - body: responseData, - headers: createHeadersFromNodeIncomingMessage(incomingMessage), - }); + if (incomingMessage.statusCode >= 400 && incomingMessage.statusCode <= 599) { + reject(new Error(JSON.stringify({ + statusCode: incomingMessage.statusCode, + body: responseData, + headers: createHeadersFromNodeIncomingMessage(incomingMessage), + }))); + } else { + resolve({ + statusCode: incomingMessage.statusCode, + body: responseData, + headers: createHeadersFromNodeIncomingMessage(incomingMessage), + }); + } }); });