nits

Author: oakbani

src/Optimizely/DecisionService/DecisionService.php

@@ -330,7 +330,7 @@ public function getVariationForFeatureRollout(ProjectConfigInterface $projectCon
             break;
         }
         // Evaluate Everyone Else Rule / Last Rule now
-        $rolloutRule = $rolloutRules[sizeof($rolloutRules)-1];
+        $rolloutRule = $rolloutRules[sizeof($rolloutRules) - 1];
 
         // Evaluate if user meets the audience condition of Everyone Else Rule / Last Rule now
         if (!Validator::doesUserMeetAudienceConditions($projectConfig, $rolloutRule, $userAttributes, $this->_logger, 'Optimizely\Enums\RolloutAudienceEvaluationLogs', 'Everyone Else')) {

tests/UtilsTests/ValidatorTest.php

@@ -188,7 +188,7 @@ public function testAreEventTagsValidInvalidEventTags()
     }
 
     // test that Audience evaluation proceeds if provided attributes are empty or null.
-    public function testdoesUserMeetAudienceConditionsAudienceUsedInExperimentNoAttributesProvided()
+    public function testDoesUserMeetAudienceConditionsAudienceUsedInExperimentNoAttributesProvided()
     {
         $configMock = $this->getMockBuilder(DatafileProjectConfig::class)
             ->setConstructorArgs(array(DATAFILE, $this->loggerMock, new NoOpErrorHandler()))
@@ -231,7 +231,7 @@ public function testdoesUserMeetAudienceConditionsAudienceUsedInExperimentNoAttr
         );
     }
 
-    public function testdoesUserMeetAudienceConditionsAudienceMatch()
+    public function testDoesUserMeetAudienceConditionsAudienceMatch()
     {
         $config = new DatafileProjectConfig(DATAFILE, new NoOpLogger(), new NoOpErrorHandler());
         $this->assertTrue(
@@ -244,7 +244,7 @@ public function testdoesUserMeetAudienceConditionsAudienceMatch()
         );
     }
 
-    public function testdoesUserMeetAudienceConditionsAudienceNoMatch()
+    public function testDoesUserMeetAudienceConditionsAudienceNoMatch()
     {
         $config = new DatafileProjectConfig(DATAFILE, new NoOpLogger(), new NoOpErrorHandler());
         $this->assertFalse(
@@ -258,7 +258,7 @@ public function testdoesUserMeetAudienceConditionsAudienceNoMatch()
     }
 
     // test that doesUserMeetAudienceConditions returns true when no audience is attached to experiment.
-    public function testdoesUserMeetAudienceConditionsNoAudienceUsedInExperiment()
+    public function testDoesUserMeetAudienceConditionsNoAudienceUsedInExperiment()
     {
         $config = new DatafileProjectConfig(DATAFILE, null, null);
         $experiment = $config->getExperimentFromKey('test_experiment');
@@ -302,7 +302,7 @@ public function testdoesUserMeetAudienceConditionsNoAudienceUsedInExperiment()
 
     // test that doesUserMeetAudienceConditions returns false when some audience is attached to experiment
     // and user attributes do not match.
-    public function testdoesUserMeetAudienceConditionsSomeAudienceUsedInExperiment()
+    public function testDoesUserMeetAudienceConditionsSomeAudienceUsedInExperiment()
     {
         $config = new DatafileProjectConfig(DATAFILE, null, null);
         $experiment = $config->getExperimentFromKey('test_experiment');
@@ -336,7 +336,7 @@ public function testdoesUserMeetAudienceConditionsSomeAudienceUsedInExperiment()
     }
 
     // test that doesUserMeetAudienceConditions evaluates audience when audienceConditions is an audience leaf node.
-    public function testdoesUserMeetAudienceConditionsWithAudienceConditionsSetToAudienceIdString()
+    public function testDoesUserMeetAudienceConditionsWithAudienceConditionsSetToAudienceIdString()
     {
         $config = new DatafileProjectConfig(DATAFILE, null, null);
         $experiment = $config->getExperimentFromKey('test_experiment');
@@ -355,7 +355,7 @@ public function testdoesUserMeetAudienceConditionsWithAudienceConditionsSetToAud
         );
     }
 
-    public function testdoesUserMeetAudienceConditionsWithUnknownAudienceId()
+    public function testDoesUserMeetAudienceConditionsWithUnknownAudienceId()
     {
         $config = new DatafileProjectConfig(DATAFILE, $this->loggerMock, new NoOpErrorHandler());
         $experiment = $config->getExperimentFromKey('test_experiment');
@@ -376,7 +376,7 @@ public function testdoesUserMeetAudienceConditionsWithUnknownAudienceId()
     }
 
     // test that doesUserMeetAudienceConditions evaluates simple audience.
-    public function testdoesUserMeetAudienceConditionsWithSimpleAudience()
+    public function testDoesUserMeetAudienceConditionsWithSimpleAudience()
     {
         $config = new DatafileProjectConfig(DATAFILE, null, null);
         $configMock = $this->getMockBuilder(DatafileProjectConfig::class)
@@ -409,7 +409,7 @@ public function testdoesUserMeetAudienceConditionsWithSimpleAudience()
     }
 
     // test that doesUserMeetAudienceConditions evaluates complex audience.
-    public function testdoesUserMeetAudienceConditionsWithComplexAudience()
+    public function testDoesUserMeetAudienceConditionsWithComplexAudience()
     {
         $config = new DatafileProjectConfig(DATAFILE_WITH_TYPED_AUDIENCES, null, null);
         $configMock = $this->getMockBuilder(DatafileProjectConfig::class)