Skip to content

Conversation

@d8vjork
Copy link

@d8vjork d8vjork commented Mar 6, 2020

Summary

I'm creating a new project from scratch, at least, I need to make it work.

Test plan

Fresh Laravel project just including the SDK (no wrappers/implementations yet), it failed with dependency conflicts.

All tests passed after monolog upgrade.

Issues

  • Sorry, it doesn't finish the issue mentioned before, it just solve the monolog part (but still some work upgrading PHPUnit dependency + tests to make it work on PHP 7.4), anyway Laravel 7 still require PHP 7.2 / 7.3, so not a major issue yet.

@d8vjork
Copy link
Author

d8vjork commented Mar 6, 2020

Also lots of unsupported PHP versions: 5.5, 5.6, 7.0 and 7.1 are out of support, 7.2 is the only way to go with this monolog upgrade

https://www.php.net/supported-versions.php

@aliabbasrizvi
Copy link
Contributor

@d8vjork we will have to take a much closer look at this, but in its current form we cannot take this change since this means dropping support for some PHP versions.

We are taking a closer look at our end on how we can introduce PHP 7.4 support and support Laravel 6 and 7.

@d8vjork
Copy link
Author

d8vjork commented Jun 4, 2020

Maybe a different branch/major version could be an option.

Thanks for the reply anyway

@raank
Copy link

raank commented Jul 23, 2020

Do we have any progress in relation to the version of the "monolog" for version "2"?

@ravanscafi
Copy link

Could we please prioritize this? It could be tagged as v4.0 or whatever is best.
This is preventing us from update our project.

@okdewit
Copy link

okdewit commented Mar 29, 2021

Feel free to use okdewit/optimizely-php-sdk v4.0.3 as a stopgap solution. It's a packagist-published fork which is regularly synced from the main branch of this repo.

I will mark my fork as deprecated when this has a tag that supports Monolog v2 and Guzzle v7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants