From ca81bad64217f32d60b36333e25b2b6d5663ec36 Mon Sep 17 00:00:00 2001 From: Owais Akbani Date: Thu, 23 Jan 2020 11:31:48 +0500 Subject: [PATCH 1/2] tests: fail unit test --- tests/test_event_processor.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tests/test_event_processor.py b/tests/test_event_processor.py index 40b28467..9027785b 100644 --- a/tests/test_event_processor.py +++ b/tests/test_event_processor.py @@ -1,4 +1,4 @@ -# Copyright 2019, Optimizely +# Copyright 2019-2020, Optimizely # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at @@ -24,6 +24,7 @@ from optimizely.event.event_factory import EventFactory from optimizely.event.log_event import LogEvent from optimizely.event.user_event_factory import UserEventFactory +from optimizely.event_dispatcher import EventDispatcher as default_event_dispatcher from optimizely.helpers import enums from optimizely.logger import SimpleLogger from . import base @@ -561,3 +562,10 @@ def on_log_event(log_event): self.assertEqual( 1, len(self.optimizely.notification_center.notification_listeners[enums.NotificationTypes.LOG_EVENT]), ) + + def test_event_processor_defaults_to_default_event_dispatcher(self): + event_processor = ForwardingEventProcessor(None) + self.assertIsInstance( + event_processor.event_dispatcher, + default_event_dispatcher + ) From 18f951de8bad7edca5d59be4fa6e91e05dbf9d80 Mon Sep 17 00:00:00 2001 From: Owais Akbani Date: Thu, 23 Jan 2020 11:44:26 +0500 Subject: [PATCH 2/2] fix: default ForwardingEventProcessor to use default event dispatcher --- optimizely/event/event_processor.py | 4 ++-- tests/test_event_processor.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/optimizely/event/event_processor.py b/optimizely/event/event_processor.py index dac1faa5..e7eebc03 100644 --- a/optimizely/event/event_processor.py +++ b/optimizely/event/event_processor.py @@ -1,4 +1,4 @@ -# Copyright 2019 Optimizely +# Copyright 2019-2020 Optimizely # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at @@ -335,7 +335,7 @@ def __init__(self, event_dispatcher, logger=None, notification_center=None): logger: Optional component which provides a log method to log messages. By default nothing would be logged. notification_center: Optional instance of notification_center.NotificationCenter. """ - self.event_dispatcher = event_dispatcher + self.event_dispatcher = event_dispatcher or default_event_dispatcher self.logger = _logging.adapt_logger(logger or _logging.NoOpLogger()) self.notification_center = notification_center or _notification_center.NotificationCenter(self.logger) diff --git a/tests/test_event_processor.py b/tests/test_event_processor.py index 9027785b..0ea0d17f 100644 --- a/tests/test_event_processor.py +++ b/tests/test_event_processor.py @@ -565,7 +565,7 @@ def on_log_event(log_event): def test_event_processor_defaults_to_default_event_dispatcher(self): event_processor = ForwardingEventProcessor(None) - self.assertIsInstance( + self.assertEqual( event_processor.event_dispatcher, default_event_dispatcher )