Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing MD --> RST #143

Merged
merged 5 commits into from
Sep 24, 2018
Merged

Changing MD --> RST #143

merged 5 commits into from
Sep 24, 2018

Conversation

aliabbasrizvi
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi commented Sep 19, 2018

Tested by confirming that all content looks fine in github.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.667% when pulling 20a11eb on ali/move_to_rst into 42d74b2 on master.

@coveralls
Copy link

coveralls commented Sep 19, 2018

Coverage Status

Coverage remained the same at 99.667% when pulling 5885708 on ali/move_to_rst into 42d74b2 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.667% when pulling 20a11eb on ali/move_to_rst into 42d74b2 on master.

@aliabbasrizvi
Copy link
Contributor Author

This has to be done to fix formatting on PyPi. See how https://pypi.python.org/pypi/optimizely-sdk looks currently and the description there only understands rst. I used this opportunity to move all MD files to RST.

@aliabbasrizvi
Copy link
Contributor Author

Any feedback here?

Copy link

@travisbeck travisbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me if things will look better in PyPI. It's mildly unfortunate though since markdown is objectively better than restructured text ;)

@aliabbasrizvi
Copy link
Contributor Author

build

1 similar comment
@aliabbasrizvi
Copy link
Contributor Author

build

@aliabbasrizvi aliabbasrizvi merged commit af38afb into master Sep 24, 2018
@aliabbasrizvi aliabbasrizvi deleted the ali/move_to_rst branch September 24, 2018 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants