Skip to content

chore: Prepare for 2.3.2 release #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 9, 2020
Merged

chore: Prepare for 2.3.2 release #76

merged 6 commits into from
Oct 9, 2020

Conversation

yavorona
Copy link
Contributor

@yavorona yavorona commented Oct 7, 2020

Summary:

  • Upgrade @optimizely/optimizely-sdk to compatible-version dependency 4.3.4
  • Fixed return type of getAllFeatureVariables method in ReactSDKClient

Test:

Existing unit tests

package.json Outdated
@@ -29,7 +29,7 @@
},
"dependencies": {
"@optimizely/js-sdk-logging": "^0.1.0",
"@optimizely/optimizely-sdk": "4.3.1",
"@optimizely/optimizely-sdk": "4.3.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged #75 , so we can make this a compatible-version dependency instead of an exact dependency:

Suggested change
"@optimizely/optimizely-sdk": "4.3.3",
"@optimizely/optimizely-sdk": "^4.3.3",

I think this can be done with the yarn add command.

@yavorona yavorona force-pushed the pnguen/2.3.2-release branch from e8e5a9f to 0d0333f Compare October 8, 2020 20:17
@yavorona yavorona requested a review from mjc1283 October 8, 2020 20:18
@yavorona yavorona merged commit a1eee23 into master Oct 9, 2020
@yavorona yavorona deleted the pnguen/2.3.2-release branch October 9, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants